RDKEMW-21356:Add functionality supporting build type - signedlab - #100
Open
KTirumalaSrihari wants to merge 1 commit into
Open
RDKEMW-21356:Add functionality supporting build type - signedlab#100KTirumalaSrihari wants to merge 1 commit into
KTirumalaSrihari wants to merge 1 commit into
Conversation
Signed-off-by: skondu363 <Srihariraghava_konduritirumala@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for a new device build type, signedlab, by extending the BUILDTYPE enum and updating build-type detection logic in GetBuildType().
Changes:
- Added
eSIGNEDLABto theBUILDTYPEenum. - Updated
GetBuildType()to detect"signedlab"and returneSIGNEDLABplus the normalized output string.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| utils/rdk_fwdl_utils.h | Extends the public BUILDTYPE enum with eSIGNEDLAB. |
| utils/common_device_api.c | Adds "signedlab" detection branch in GetBuildType(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
50
to
57
| typedef enum { | ||
| eUNKNOWN, | ||
| eDEV, | ||
| eVBN, | ||
| ePROD, | ||
| eQA | ||
| eQA, | ||
| eSIGNEDLAB | ||
| } BUILDTYPE; |
Comment on lines
50
to
57
| typedef enum { | ||
| eUNKNOWN, | ||
| eDEV, | ||
| eVBN, | ||
| ePROD, | ||
| eQA | ||
| eQA, | ||
| eSIGNEDLAB | ||
| } BUILDTYPE; |
| pOut = "prod"; | ||
| eBuildType = ePROD; | ||
| } | ||
| else if( strstr( pTmp, "signedlab" ) != NULL ) |
Comment on lines
+320
to
+324
| else if( strstr( pTmp, "signedlab" ) != NULL ) | ||
| { | ||
| pOut = "signedlab"; | ||
| eBuildType = eSIGNEDLAB; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.