RDKOSS-22272 : Main Change in sup_8.3.4.0 - #118
Open
PreethiALPI wants to merge 1 commit into
Open
Conversation
Reason for change: crash Test Procedure: Factory reset Risks: Medium Priority: P0 Signed-off-by: ppalan289 <preethi_palanisamy@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Bluetooth manager deinitialization to more reliably complete disconnects for certain connected audio devices (speakers/headsets), aiming to prevent a crash during teardown (noted test procedure: factory reset).
Changes:
- Adds a post-disconnect polling loop in
BTRMGR_DeInitto confirm device disconnection for speakers/headsets (with a bounded timeout). - Adds log messages for disconnect confirmation/timeout outcomes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4036
to
+4049
| if (lenBtrCoreDevTy == enBTRCoreSpeakers || lenBtrCoreDevTy == enBTRCoreHeadSet) { | ||
| unsigned int ui32PollCount = 10; /* 10 × 100ms = 1000ms max */ | ||
|
|
||
| do { | ||
| usleep(100000); /* 100ms */ | ||
| lenBtrCoreRet = BTRCore_GetDeviceDisconnected(ghBTRCoreHdl,lstConnectedDevices.m_deviceProperty[ui16LoopIdx].m_deviceHandle,lenBtrCoreDevTy); | ||
| } while ((lenBtrCoreRet != enBTRCoreSuccess) && (--ui32PollCount)); | ||
|
|
||
| if (!ui32PollCount) { | ||
| BTRMGRLOG_WARN("Disconnect confirmation timeout for device %llu\n", lstConnectedDevices.m_deviceProperty[ui16LoopIdx].m_deviceHandle); | ||
| } else { | ||
| BTRMGRLOG_WARN("Disconnect confirmed for device %llu in %dms\n", lstConnectedDevices.m_deviceProperty[ui16LoopIdx].m_deviceHandle, (10 - ui32PollCount) * 100); | ||
| } | ||
| } |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: crash
Test Procedure: Factory reset
Risks: Medium
Priority: P0