Skip to content

RDKBNETWOR-76 : Implementation of Wireguard VPN. - #1

Draft
kavitavakkund610 wants to merge 4 commits into
mainfrom
RDKBNETWOR-76
Draft

RDKBNETWOR-76 : Implementation of Wireguard VPN.#1
kavitavakkund610 wants to merge 4 commits into
mainfrom
RDKBNETWOR-76

Conversation

@kavitavakkund610

Copy link
Copy Markdown
Contributor

Reason for change: Implementation of Wireguard VPN to support both Client and Server through RdkVpnManager.
Test Procedure: Set the Vpn DataModels with the respective parameters based on the requirement and establish the connection.
Testing Done : Results are captured in RDKBNETWOR-76
Risks: None.

Reason for change: Implementation of Wireguard VPN to support both Client and Server through RdkVpnManager.
Test Procedure: Set the Vpn DataModels with the respective parameters based on the requirement and establish the connection.
Testing Done : Results are captured in RDKBNETWOR-76
Risks: None.

Signed-off-by: Kavita Vakkund <kavita.vakkund@telekom-digital.com>
@CLAassistant

CLAassistant commented Jul 28, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@rdkcmf-jenkins

Copy link
Copy Markdown
Contributor

b'## Copyright scan failure
Commit: d9baee7
Report detail: https://gist.github.com/rdkcmf-jenkins/c9b3fea34d5516cb97a5e9162414d226'

@rdkcmf-jenkins

Copy link
Copy Markdown
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 21 files pending identification.

  • Protex Server Path: /home/blackduck/github/RdkVpnManager/1/rdkcentral/RdkVpnManager

  • Commit: d9baee7

Report detail: gist'

@mhughesacn

Copy link
Copy Markdown

This repo needs standard license files:

  • CONTRIBUTING.md (github standard, see rdkcentral/unified-wifi-mesh)

  • COPYING soft link to LICENSE

  • LICENSE to contain Apache-2 license and FSF Unlimited. See rdkcentral/unified-wifi-mesh/LICENSE but without the BSD license.

  • NOTICE based off rdkcentral/telemetry/NOTICE lines 1-8 with the first line changed to you, and append:
    Copyright (C) 1994-2013 Free Software Foundation, Inc.
    Licensed under the FSF Unlimited License (with License Retention)

  • There is code here from other RDK components which should be credited. Add this to NOTICE:

Copyright 2015 RDK Management
Licensed under the Apache License, Version 2.0

Copyright [2014] [Cisco Systems, Inc.]
Licensed under the Apache License, Version 2.0

8 Strictly, each re-use of RDK code should be credited, and I have 6 code matches to CcspPandM. If you know all of the “borrows”, you should add a credit under the DT header in each file, with this:

sig_handler is modified from code which is:
Copyright 2015 RDK Management
Licensed under the Apache License, Version 2.0

Copyright [2014] [Cisco Systems, Inc.]
Licensed under the Apache License, Version 2.0

Reason for change: Implementation of Wireguard VPN to support both Client and Server through RdkVpnManager.
Test Procedure: Set the Vpn DataModels with the respective parameters based on the requirement and establish the connection.
Testing Done : Results are captured in RDKBNETWOR-76
Risks: None.

Signed-off-by: Kavita Vakkund <kavita.vakkund@telekom-digital.com>
@rdkcmf-jenkins

Copy link
Copy Markdown
Contributor

b'## Copyright scan failure
Commit: f97e391
Report detail: https://gist.github.com/rdkcmf-jenkins/f3900f82312726d228467f22ddd6c97e'

@rdkcmf-jenkins

Copy link
Copy Markdown
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 13 files pending identification.

  • Protex Server Path: /home/blackduck/github/RdkVpnManager/1/rdkcentral/RdkVpnManager

  • Commit: f97e391

Report detail: gist'

@mhughesacn mhughesacn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi.
I appreciate that this is draft but I have looked at the blackduck issues which are needed before PR approval as the component is already opensourced.

  • One change to NOTICE.

  • Please add a credit after the header in the following files: ssp_main.c and ssp_messagebus_interface.c to say:
    sig_handler is modified from code which is:
    Copyright 2015 RDK Management
    Licensed under the Apache License, Version 2.0
    Copyright [2014] [Cisco Systems, Inc.]
    Licensed under the Apache License, Version 2.0

  • In plugin_main.c at line 25, add the 4 lines of RDK and Cisco credit/Apache license.

  • In plugin_main_apis.c, under the header, add "Uses code which is" and the same 4 lines.

  • Ignoring 2 other code matches in other files, v.small.
    Thank you.

Comment thread NOTICE Outdated
@@ -0,0 +1,17 @@
This component contains software that is Copyright (c) 2018 RDK Management.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change RDK Management on line 1 to Deutsche Telekom AG (assuming this repo is from DT).

@rdkcmf-jenkins

Copy link
Copy Markdown
Contributor

b'## Copyright scan failure
Commit: 5dde781
Report detail: https://gist.github.com/rdkcmf-jenkins/82e775848b00644c351f54c9142b0ab6'

@rdkcmf-jenkins

Copy link
Copy Markdown
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 7 files pending identification.

  • Protex Server Path: /home/blackduck/github/RdkVpnManager/1/rdkcentral/RdkVpnManager

  • Commit: 5dde781

Report detail: gist'

@rdkcmf-jenkins

Copy link
Copy Markdown
Contributor

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

  • Upvote reason: Thank you!

  • Commit: 5dde781
    '

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants