RDKB-65720: CCI crash during beacon data parsing (#34) - #36
Merged
Conversation
Impacted Platforms: TXB7, TXB8, VXB10, SXB10 Reason for change: Failed to parse the start_ap_data Test Procedure: Trigger any VAP configuration test case from CCI. Risks: Low Priority: P2 Signed off by: RaviShankar.R_Rangaraj@comcast.com
There was a problem hiding this comment.
Pull request overview
Fixes a crash seen on multiple RDKB platforms when parsing cfg80211 start_ap (beacon) messages by aligning the parser with the actual message layout and storing SSID information in the message data structure.
Changes:
- Parse SSID length and SSID bytes in
handle_cfg80211_start_ap()before reading beacon head/tail lengths. - Add SSID buffer and
ssid_lenfields to thewlan_emu_cfg80211_start_ap_tmessage structure.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/messages/wlan_emu_msg_hdlr.cpp |
Updates cfg80211 start_ap parsing to include SSID length/data before beacon head/tail parsing. |
inc/wlan_emu_msg_data.h |
Extends start_ap message struct to carry SSID and its length. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gsathish86
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impacted Platforms: TXB7, TXB8, VXB10, SXB10
Reason for change: Failed to parse the start_ap_data
Test Procedure: Trigger any VAP configuration test case from CCI.
Risks: Low
Priority: P2
Signed off by: RaviShankar.R_Rangaraj@comcast.com