RDKB-64575 : Move mesh script from Onewifi to meshAgent - #1306
Open
arifcep wants to merge 3 commits into
Open
Conversation
Reason for change: move meshAgent related scripts from Onewifi to meshAgent Test Procedure: validate these scripts are part of rootfs via mesh-agent receipe Risks: Low Priority: P1 Signed-off-by: mmanno374_comcast <MohammedArif_MannoppillyHassan@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes several meshAgent-related shell scripts from the OneWifi repository as part of migrating ownership of those scripts to the meshAgent component (per RDKB-64575), so they are expected to be delivered via the mesh-agent recipe/rootfs instead of OneWifi.
Changes:
- Deleted mesh backhaul/bridge configuration scripts (
mesh_setip.sh,meshapcfg.sh). - Deleted mesh status/telemetry helper script (
mesh_status.sh). - Deleted mesh MAC ACL helper and opensync manager wrapper script (
mesh_aclmac.sh,handle_mesh).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/meshapcfg.sh | Removed mesh backhaul SSID/VLAN/AP configuration script from OneWifi. |
| scripts/mesh_status.sh | Removed periodic mesh status logging/telemetry script from OneWifi. |
| scripts/mesh_setip.sh | Removed mesh bridge IP/MTU configuration script from OneWifi. |
| scripts/mesh_aclmac.sh | Removed mesh backhaul MAC ACL management script from OneWifi. |
| scripts/handle_mesh | Removed opensync/mesh manager init wrapper script from OneWifi. |
Comments suppressed due to low confidence (1)
scripts/mesh_setip.sh:1
mesh_setip.shis removed from this repo, but/usr/ccsp/wifi/process_monitor_atom.shstill invokes/usr/ccsp/wifi/mesh_setip.sh(see scripts/process_monitor_atom.sh:946 in current tree). Unless the meshAgent recipe guarantees installing this script at the exact same path on all targets, this will cause the self-heal path to fail with "not found" and leave mesh bridge IPs unset. Please either (a) keep a thin wrappermesh_setip.shhere that forwards to the new meshAgent location, or (b) update the caller(s)/service integration to the new path and ensure the dependency is explicit.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gsathish86
approved these changes
Jul 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
scripts/mesh_setip.sh:1
- This script is being removed, but the codebase still invokes it at runtime: scripts/process_monitor_atom.sh:946 runs
sh /usr/ccsp/wifi/mesh_setip.shwhen mesh bridge IPs are missing. With this deletion and no replacement path in this repo, that self-heal path will fail unless meshAgent installs a compatible script at the same location (or the caller is updated). Please either (a) keep a compatibility wrapper here that delegates to the new meshAgent location, or (b) update the caller(s) to the new path and ensure it’s present in the rootfs.
Contributor
|
@arifcep i do not see corresponding PR to mesh repository. Why? If this gets merged without this script already there, builds will break. |
narendradandu
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: move meshAgent related scripts from Onewifi to meshAgent
Test Procedure: validate these scripts are part of rootfs via mesh-agent receipe
Risks: Low
Priority: P1
Dependent changes
https://gerrit.teamccp.com/#/q/topic:mesh_script-26Q3_sprint+(status:open+OR+status:merged)
https://github.com/rdk-gdcs/mesh-agent/pull/23