Skip to content

RDKBACCL-1702: [TDK][AUTO][BPI][DML]Setting Device.WiFi.AccessPoint.<i>.WPS.X_CISCO_COM_CancelSession causes OneWiFi crash #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ap934 wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

RDKBACCL-1702: [TDK][AUTO][BPI][DML]Setting Device.WiFi.AccessPoint.<i>.WPS.X_CISCO_COM_CancelSession causes OneWiFi crash #1290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4eecfa0
RDKBACCL-1702: [TDK][AUTO][BPI][DML]Setting Device.WiFi.AccessPoint.<…
ap934 Jul 23, 2026
cc1e356
Send INT vap index for WPS cancel event
ap934 Jul 23, 2026
cc556b8
Merge branch 'develop' into handle_wps_cancel_on_non-wps_vaps
gsathish86 Jul 27, 2026
ed29771
Merge branch 'develop' into handle_wps_cancel_on_non-wps_vaps
gsathish86 Jul 27, 2026
6a0b97c
Merge branch 'develop' into handle_wps_cancel_on_non-wps_vaps
ap934 Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions source/core/wifi_ctrl_queue_handlers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3231,6 +3231,12 @@ static void process_wps_cancel_event(void *data)

INT vap_index = *(INT*)data;

if (!isVapPrivate(vap_index)) {
wifi_util_error_print(WIFI_CTRL,"%s:%d WPS not applicable for vap index %d, ignoring cancel\n",
__func__, __LINE__, vap_index);
return;
}

wifi_util_info_print(WIFI_CTRL,"%s:%d wps pbc cancel vap index = %d\n",
__func__, __LINE__, vap_index);
wifi_hal_setApWpsCancel(vap_index);
Expand Down
10 changes: 7 additions & 3 deletions source/dml/tr_181/ml/cosa_wifi_dml.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12405,9 +12405,13 @@ WPS_SetParamBoolValue
}
if( AnscEqualString(ParamName, "X_CISCO_COM_CancelSession", TRUE))
{
instance_number -= 1;
wifi_util_dbg_print(WIFI_DMCLI,"%s:%d: WPS cancel for vap %d\n",__func__, __LINE__, instance_number);
push_event_to_ctrl_queue(&instance_number, sizeof(instance_number), wifi_event_type_command, wifi_event_type_command_wps_cancel, NULL);
if (vapInfo->u.bss_info.wps.enable == false) {
wifi_util_error_print(WIFI_DMCLI,"%s:%d: WPS not enabled for %s, cancel session not supported\n",__func__, __LINE__, vapInfo->vap_name);
return FALSE;
Comment thread
gsathish86 marked this conversation as resolved.
}
INT vap_index = (INT)(instance_number - 1);
wifi_util_dbg_print(WIFI_DMCLI,"%s:%d: WPS cancel for vap %d\n",__func__, __LINE__, vap_index);
push_event_to_ctrl_queue(&vap_index, sizeof(vap_index), wifi_event_type_command, wifi_event_type_command_wps_cancel, NULL);
return TRUE;
}
#else
Expand Down
12 changes: 9 additions & 3 deletions source/platform/common/data_model/wifi_dml_cb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4820,10 +4820,16 @@ bool wps_set_param_bool_value(void *obj_ins_context, char *param_name, bool outp
}
}
} else if (STR_CMP(param_name, "X_CISCO_COM_CancelSession")) {
instance_number -= 1;
if (p_dm_vap_info->u.bss_info.wps.enable == false) {
wifi_util_error_print(WIFI_DMCLI,
"%s:%d: WPS not enabled for %s, cancel session not supported\n",
__func__, __LINE__, p_dm_vap_info->vap_name);
Comment thread
mateuszCieslak-GL marked this conversation as resolved.
return false;
}
INT vap_index = (INT)(instance_number - 1);
wifi_util_dbg_print(WIFI_DMCLI, "%s:%d: WPS cancel for vap %d\n", __func__, __LINE__,
instance_number);
push_event_to_ctrl_queue(&instance_number, sizeof(instance_number), wifi_event_type_command,
vap_index);
push_event_to_ctrl_queue(&vap_index, sizeof(vap_index), wifi_event_type_command,
wifi_event_type_command_wps_cancel, NULL);
} else {
wifi_util_info_print(WIFI_DMCLI, "%s:%d: unsupported param name:%s\n", __func__, __LINE__,
Expand Down
Loading