Skip to content

fix(docker): apply host networking via compose override in dockerw #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cleithner-comcast wants to merge 4 commits into
base: main
Choose a base branch
from
+10 −4
Open

fix(docker): apply host networking via compose override in dockerw #257

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c885b25
fix(docker): apply host networking via compose override in dockerw
cleithner-comcast Aug 4, 2026
12849fb
Potential fix for pull request finding
cleithner-comcast Aug 4, 2026
da66ffd
fix(docker): expand COMPOSE_FILES array correctly in dockerw
cleithner-comcast Aug 4, 2026
f56806c
Merge branch 'main' into cleith/dev/fixHostNetworkCompose
cleithner-comcast Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions dockerw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ while getopts ":ne:dH" opt; do
DEV_VOL="-v /dev:/dev"
;;
H) # use host networking (useful for Matter device access)
HOST_NETWORK="--network host"
HOST_NETWORK="1"
;;
esac
done
Expand All @@ -62,7 +62,14 @@ DIR=$(pwd)
# generate the `docker/.env` file and ensure the network/image is created
$DIR/docker/setupDockerEnv.sh

COMPOSE_FILE="${DIR}/docker/compose.yaml"
# `docker compose run` has no `--network` flag, so host networking is applied by
# layering the host-network override compose file (which sets network_mode: host
# and resets the base network) rather than passing a flag to the run command.
COMPOSE_FILES=(-f "${DIR}/docker/compose.yaml")

if [ -n "$HOST_NETWORK" ]; then
COMPOSE_FILES+=(-f "${DIR}/docker/compose.host-network.yaml")
fi
Comment thread
cleithner-comcast marked this conversation as resolved.

EXTRA_VOLUMES="${DEV_VOL}"

Expand All @@ -74,11 +81,10 @@ USER_ID=$(id -u -n)
RANDOM_NUMBER=$(shuf -i 100000-999999 -n 1)
CONTAINER_NAME="${USER_ID}_${RANDOM_NUMBER}"

docker compose -f "${COMPOSE_FILE}" run \
docker compose "${COMPOSE_FILES[@]}" run \
Comment thread
cleithner-comcast marked this conversation as resolved.
--rm \
--name ${CONTAINER_NAME} \
${COMPOSE_INTERACTIVE_FLAGS} \
${HOST_NETWORK} \
--workdir "${DIR}" \
${VOLUMES_ARGS} \
${EXTRA_ENV} \
Expand Down
Loading