feat: Add option to disable V-Sync#43
Conversation
This commit introduces a `--no-vsync` command-line flag to allow disabling V-Sync. When V-Sync is enabled, the application's frame rate is capped at the monitor's refresh rate, which can cause significant performance bottlenecks, particularly during the buffer swap. - Added a `vsync` option to the `AppConfig` dataclass, defaulting to `True`. - Added a `--no-vsync` command-line argument to set the `vsync` option to `False`. - Added a call to `glfw.swap_interval(0)` in `app.py` when `vsync` is `False` to disable V-Sync.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
This change introduces a
--no-vsynccommand-line flag to address performance issues caused by V-Sync. By disabling V-Sync, the application can run at a higher frame rate, uncapped by the monitor's refresh rate.PR created automatically by Jules for task 15823696489268458149