Add admin_settings table with grouped JSON config columns#25
Merged
Conversation
Introduces the admin_settings singleton table for runtime configuration
with three jsonb columns instead of a single value blob, so unrelated
sections can be patched independently:
- ai_configuration: AI provider/model/secret config
- login_settings: auth method + registration options
- extended_settings: forward-compatible catch-all for future sections
Each column is NOT NULL defaulting to '{}'. Standard id/created_at/
updated_at columns and the admin_ group prefix follow the schema rules.
Exports the table from schema/index.ts and adds the generated Drizzle
migration.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TWzYnSpeJoYnYrXL8WVJ3B
Implements the admin-settings-auth-pages phase. Two capabilities built on the grouped-column admin_settings schema: Auth pages & approval - Standalone /login, /register, /reset-password (+ /reset-password/[token]) on a shared email+password AuthForm; /admin/login redirects to /login?next=/admin. - Better Auth password-reset flow wired to a logging mailer stub. - core_users.status (active/pending/rejected): new sign-ups land pending unless approval is disabled; session creation is blocked for non-active accounts via databaseHooks. /admin/users gains a pending queue + status column. Runtime settings store - SettingsService merges DB-over-env per field, caches with a version for lazy auth rebuild, resolves/decrypts AI keys, redacts secrets to set/unset. - DrizzleSettingsRepository maps the three jsonb columns (login_settings, ai_configuration, extended_settings); idempotent env seed on first boot. - AesSecretCipher (AES-256-GCM) keyed by APP_SETTINGS_ENCRYPTION_KEY; provider factory + LanguageModelAdapter take a per-request key so provider/key changes apply with no redeploy. - /admin/settings: Login Methods + AI Configuration cards with masked secrets and per-section env/db source hints. - tRPC settings router (settings.manage) and user approve/reject/listPending (users.write). Config & docs - env APP_SETTINGS_ENCRYPTION_KEY (base64->32 bytes, required in prod); both installers generate it and note runtime config moved to /admin/settings. - Tests written first for shared schema, SettingsService, approval use-cases, AesSecretCipher, and the installer key helper. - VERSION/package.json -> 1.2.0; changeset; phase doc moved to implemented/v1.2.0 with an implementation summary documenting the grouped-column deviation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TWzYnSpeJoYnYrXL8WVJ3B
Pass an explicit authTagLength to createCipheriv/createDecipheriv so a truncated authentication tag cannot be accepted on decrypt. Resolves the Semgrep gcm-no-tag-length blocking finding in the security scan. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TWzYnSpeJoYnYrXL8WVJ3B
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the admin_settings singleton table for runtime configuration
with three jsonb columns instead of a single value blob, so unrelated
sections can be patched independently:
Each column is NOT NULL defaulting to '{}'. Standard id/created_at/
updated_at columns and the admin_ group prefix follow the schema rules.
Exports the table from schema/index.ts and adds the generated Drizzle
migration.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01TWzYnSpeJoYnYrXL8WVJ3B