Fix warnings - #34
Merged
Merged
Conversation
rboston628
marked this pull request as ready for review
July 4, 2026 19:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THRAIN is my dissertation code. I made it while a graduate student at UNC, and it wa entirely developed using an Intel Mac running GCC. I had multiple warning flags turned on, and THRAIN always built locally without compiler error or warning.
When I setup the automatic GitHub CI/CD, I discovered there were hundreds of errors when building on other systems (including when building on Mac with clang).
This has been a long standing nuisance, especially when trying to debug errors on systems, where the unit tests are littered with warning statements.
The purpose of this PR is to clear out the compiler warnings.
Check compilers. There should be no compiler warnings.
From now on, compile warnings on any system will be treated as an error, to prevent further warnings from building up.