feat(pdf): add --puppeteer-arg option to export command - #21
Conversation
Add --nosandbox/-n option to pass to puppeteer for gitlab compatability
rbardini
left a comment
There was a problem hiding this comment.
Thank you! Happy to merge this, only have a couple requests:
|
Can we push that PR? I'm struggling with the same issue on GitHub Actions :) |
|
@kwilliamyoung Would you be able to fix the review comments? Looks like Sade does support repeated options, so a generic |
|
Hi all,
Sorry for the delayed response, yes I halfway added it. I'll try and send
an updated PR tonight.
Thanks
Will
|
|
Same problem with GHA for me |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 153 157 +4
Branches 23 26 +3
=========================================
+ Hits 153 157 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@kwilliamyoung I took the liberty of fixing the review comments to unblock the PR, hope you don't mind. Planning to merge and release it later today. |
--puppeteer-arg option to export command
|
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks for taking a look, I appreciate the feedback!