Skip to content

[rayci] 0 retries for exit code 42 (test failures)#493

Merged
elliot-barn merged 1 commit into
mainfrom
elliot-barn-update-retries-on-bazel-test-fail
Jun 16, 2026
Merged

[rayci] 0 retries for exit code 42 (test failures)#493
elliot-barn merged 1 commit into
mainfrom
elliot-barn-update-retries-on-bazel-test-fail

Conversation

@elliot-barn

Copy link
Copy Markdown
Collaborator

Removing buildkite job retries for exit code 42 (test failures) for cost savings
Retries are already enabled at the bazel test level and are configurable per job in the bk config

Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the automatic retry configuration in raycicmd/bk_pipeline.go to omit retries for test failures (exit status 42), since Bazel already handles them. The reviewer pointed out a minor typo in an inline comment ("exist status" instead of "exit status") and provided a code suggestion to fix it.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread raycicmd/bk_pipeline.go
m := []any{
map[string]int{"exit_status": 1, "limit": 1}, // unknown exist status
map[string]int{"exit_status": 42, "limit": 1}, // test failures
map[string]int{"exit_status": 1, "limit": 1}, // unknown exist status

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a small typo in the inline comment: "exist status" should be "exit status" to match the terminology used elsewhere in the function.

Suggested change
map[string]int{"exit_status": 1, "limit": 1}, // unknown exist status
map[string]int{"exit_status": 1, "limit": 1}, // unknown exit status

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@elliot-barn elliot-barn merged commit c890d24 into main Jun 16, 2026
2 checks passed
@elliot-barn elliot-barn deleted the elliot-barn-update-retries-on-bazel-test-fail branch June 16, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants