[core] Revert async object pubsub posting for Serve throughput#64391
Open
kiwoongyoon wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the PostingPublisher decorator class, its header file, and its associated build targets. The CoreWorkerProcessImpl now instantiates and uses pubsub::Publisher directly instead of wrapping it in a PostingPublisher. There are no review comments, and I have no feedback to provide.
Signed-off-by: kiwoong <rldnddbs@naver.com>
8776086 to
0316f36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: [core] Revert async object pubsub posting for Serve throughput
Summary
This removes the
PostingPublisherwrapper from core worker object pubsub publishing and returns object info publishing to directpubsub::Publishercalls. The change targets the Serve single-replica throughput regression reported after #63983.The borrowed-reference regression test added by #63983 is preserved; this patch only removes the async posting implementation and its now-unused Bazel target.
Test evidence
git diff --checkpassed.python -m py_compile python/ray/tests/test_reference_counting_standalone.pypassed.rg -n "PostingPublisher|posting_publisher" src/ray python/rayfound no remaining references.git diff --exit-code -- python/ray/tests/test_reference_counting_standalone.pypassed, confirming the correctness regression test remains unchanged.git diff --exit-code ecec4e589a -- src/ray/core_worker/BUILD.bazel src/ray/core_worker/core_worker_process.cc src/ray/pubsub/BUILD.bazel src/ray/pubsub/posting_publisher.hpassed, confirming the C++/Bazel portion matches the upstream revert branch.Risks or notes for maintainers
import rayfailed in the local Python environment.Related issue: #64347