Skip to content

[DO NOT MERGE][release] ray 2.56.0 windows image fix #64372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elliot-barn wants to merge 3 commits into
base: releases/2.56.0
Choose a base branch
from
+11 −2
Open

[DO NOT MERGE][release] ray 2.56.0 windows image fix #64372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d97dd95
[ci] windows: pin pyopenssl in conda base to fix cryptography skew (#…
elliot-barn Jun 26, 2026
79b63b7
[ci] windows: TEMP release-build BUILDKITE_COMMIT override (DO NOT ME…
elliot-barn Jun 26, 2026
9b7ae07
[ci] windows: route broker wheel upload to release prefix (DO NOT MERGE)
elliot-barn Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .buildkite/windows.rayci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,15 @@ steps:
job_env: WINDOWS
instance_type: windows
commands:
# RELEASE-BUILD OVERRIDE (DO NOT MERGE): stamp the wheels with the real 2.56.0
# release commit, even though this branch's HEAD carries the windowsbuild fix.
# build-wheel-windows.sh reads BUILDKITE_COMMIT for ray.__commit__; the env is
# forwarded into the container via _DOCKER_ENV. Drop these lines for the clean PR.
# BUILDKITE_BRANCH routes the broker upload (copy_files.py key is
# {BUILDKITE_BRANCH}/{BUILDKITE_COMMIT}/{fn}) to the release prefix the PyPI
# upload reads from, so no post-hoc S3 copy is needed.
- export BUILDKITE_COMMIT=637fd062205393b9e1929996bfe1d49bd3f8469d
Comment on lines +42 to +49

@gemini-code-assist gemini-code-assist Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The temporary release-build override ('export BUILDKITE_COMMIT=...') and its associated comments should be removed before merging this pull request to prevent hardcoding the commit hash for future builds on this branch.

- export BUILDKITE_BRANCH=releases/2.56.0
- bash ci/ray_ci/windows/install_tools.sh
- bazel run //ci/ray_ci:build_in_docker_windows -- wheel --python-version {{matrix}} --operating-system windows --upload
matrix:
Expand Down
4 changes: 2 additions & 2 deletions ci/ray_ci/windows/build_base.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ conda init
# Conda 26.3.1 crashes on Windows when it tries to clean up a locked exe during
# a build-variant swap. Preventing self-update avoids that code path.
conda config --set auto_update_conda false
conda install -q -y python="${PYTHON_FULL_VERSION}" requests=2.32.3
conda install -q -y python="${PYTHON_FULL_VERSION}" requests=2.32.3 pyopenssl=23.2.0
# Force CA trust stack to the newest versions available at build time.
conda update -c conda-forge -q -y ca-certificates certifi
conda update --freeze-installed -c conda-forge -q -y ca-certificates certifi

# Install torch first, as some dependencies (e.g. torch-spline-conv) need torch to be
# installed for their own install.
Expand Down
Loading