ray-operator: disallow overriding Serve Service names#4954
Open
andrewsykim wants to merge 2 commits into
Open
Conversation
andrewsykim
requested review from
MortalHappiness,
kevin85421 and
rueian
as code owners
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
andrewsykim
force-pushed
the
fix-service-name-override
branch
from
85eb1a2 to
36d3257
Compare
win5923
reviewed
Jun 30, 2026
win5923
left a comment
win5923
left a comment
Member
There was a problem hiding this comment.
I think this is a breaking change for users who rely on spec.serveService.metadata.name. Would it make sense to first emit a warning indicating that this will be rejected in the next release?
Member
Author
|
Do you know any users using this? I was worried about that too initially, but we don't allow overriding Service name for HeadService. |
Member
|
IDK, but i agree this change. We could remove this sample YAML as well, or just remove the name field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Similar to how we have validation for Head Services to disallow name overrides, we should similarly have validation for Serve services. The embedded Service is for overriding fields in Service.Spec but not the name itself.
Related issue number
Checks