Run tests on PHP 8.5 and update test environment#77
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the test suite and CI workflow to ensure the project continues to run cleanly on newer PHP versions (including PHP 8.5), aligning with prior compatibility work referenced in #75.
Changes:
- Adjust unit tests to avoid calling
Reflection*::setAccessible(true)on PHP ≥ 8.1. - Update GitHub Actions CI environment to Ubuntu 24.04 and expand the PHP matrix to include 8.5.
- Bump the
actions/checkoutaction major version used by CI.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/unit/Messaging/MessageBufferTest.php |
Conditionalizes reflection accessibility toggles to avoid PHP ≥ 8.1 issues while keeping compatibility for older PHP. |
tests/unit/Messaging/FrameTest.php |
Same reflection accessibility gating to keep unit tests compatible across supported PHP versions. |
.github/workflows/ci.yml |
Updates CI runner OS, adds PHP 8.5 to the test matrix, and updates the checkout action version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #75 and clue/framework-x#297