Skip to content

Limit supporte values of --org for verify-codeowners#140

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
KyleFromNVIDIA:codeowners-org-choices
Jun 29, 2026
Merged

Limit supporte values of --org for verify-codeowners#140
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
KyleFromNVIDIA:codeowners-org-choices

Conversation

@KyleFromNVIDIA

@KyleFromNVIDIA KyleFromNVIDIA commented Jun 29, 2026

Copy link
Copy Markdown
Member

The argument was already implicitly limited to these values due to how the code is structured, but codify the limitation in the arguments.

@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner June 29, 2026 16:40

@jameslamb jameslamb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used this before, but from my read of https://docs.python.org/3/library/argparse.html#choices this would mean that values not in this list are rejected.

argument values will be checked, and an error message will be displayed if the argument was not one of the acceptable values

I'm fine with being strict for now until we have a known reason to support more orgs, but just would ask that you change the PR title (which will show up in the release notes) to reflect that that was the intent.

Something like "verify-codeowners: limit supported values of --org".

"add choices" sounds like we're expanding the set of available values, but the code is actually restricting the set of supported values.

@KyleFromNVIDIA

Copy link
Copy Markdown
Member Author

I'm fine with being strict for now until we have a known reason to support more orgs

Other orgs were already not supported (at least for CI and packaging), since those would reference nonexistent entries in the dictionaries. This simply codifies the restriction.

I'll update the title.

@KyleFromNVIDIA KyleFromNVIDIA changed the title Add choices to --org argument Limit supporte values of --org for verify-codeowners Jun 29, 2026
@KyleFromNVIDIA

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot rapids-bot Bot merged commit b9a367d into rapidsai:main Jun 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants