Skip to content

Avoid overflow in remote read bounds checks#985

Open
fallintoplace wants to merge 4 commits into
rapidsai:mainfrom
fallintoplace:fix-remote-bounds-overflow
Open

Avoid overflow in remote read bounds checks#985
fallintoplace wants to merge 4 commits into
rapidsai:mainfrom
fallintoplace:fix-remote-bounds-overflow

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

Summary

  • avoid overflow in remote read bounds checks by comparing file_offset before subtracting from _nbytes
  • use the same bounds helper in direct RemoteHandle::read() and the MULTI_POLL pread() setup path
  • add a regression test for a wrapping file_offset + size range that must fail before range setup

Validation

  • pre-commit run --files cpp/src/remote_handle.cpp cpp/tests/test_remote_handle.cpp
  • git diff --check

Not run locally: ci/run_ctests.sh -R REMOTE_HANDLE_TEST because no installed/devcontainer KvikIO test build was present at the paths searched by the script.

@fallintoplace
fallintoplace requested a review from a team as a code owner June 23, 2026 19:42
@copy-pr-bot

copy-pr-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vuule vuule added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jul 16, 2026
@vuule

vuule commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

/ok to test 3ebae94

@vyasr

vyasr commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Needs style fixes before CI can run properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants