Support device buffer for the new libcurl multi poll-based backend (5/n)#966
Open
kingcrimsontianyu wants to merge 85 commits into
Open
Support device buffer for the new libcurl multi poll-based backend (5/n)#966kingcrimsontianyu wants to merge 85 commits into
kingcrimsontianyu wants to merge 85 commits into
Conversation
Co-authored-by: Lawrence Mitchell <wence@gmx.li>
Contributor
Author
|
Sending this PR to draft. The reactor thread logic is very messy and can potentially be improved by RAII. Refactoring to have a cleaner code now. |
kingcrimsontianyu
marked this pull request as draft
July 20, 2026 19:09
Contributor
Author
Performance results
The results above show that: (1) For EC2-S3, there exists certain level of network bandwidth variance. (2) Comparing the best results, the new multi-poll backend is ~3% slower than the existing easy thread pool backend, with the benefit of thread usage cut by a factor of 16. |
kingcrimsontianyu
marked this pull request as ready for review
July 24, 2026 19:41
Contributor
Author
Event pool vs on-the-fly creation/destructionOn a temporary branch, the event pool was modified such that the
cc @madsbk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports device buffer for the multi poll-based remote I/O backend. In addition, this PR makes 3 improvements:
ConcurrentRequestLimiterwith RAII Slot.try_acquire()now returns a move-onlySlotthat auto-releases on destruction. Acquire/release pairing is now structurally enforced.CurlMultiAttachmentRAII guard, that removes the easy handle from the multi handle on destruction.curl_multi_wakeupcalls from the initial "per sub-range" to the current "per reactor, per pread"._inbox(shared by the submission thread and reactor thread) to a reactor-private_pendingdeque, to decouple the submission latency from reactor's admission walk.