Skip to content

Replace CUDA 13.2 with 13.3 for RAPIDS devcontainers #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bdice wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace CUDA 13.2 with 13.3 for RAPIDS devcontainers #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions ...ontainer/cuda13.2-conda/devcontainer.json → ...ontainer/cuda13.3-conda/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,26 +3,26 @@
"context": "${localWorkspaceFolder}/.devcontainer",
"dockerfile": "${localWorkspaceFolder}/.devcontainer/rapids.Dockerfile",
"args": {
"CUDA": "13.2",
"CUDA": "13.3",
"PYTHON_PACKAGE_MANAGER": "conda",
"BASE": "rapidsai/devcontainers:26.08-cpp-mambaforge"
},
"cacheFrom": [
"ghcr.io/rapidsai/devcontainers/devcontainer:26.08-cuda13.2-conda"
"ghcr.io/rapidsai/devcontainers/devcontainer:26.08-cuda13.3-conda"
]
},
"runArgs": [
"--rm",
"--name",
"${localEnv:USER:anon}-rapids-${localWorkspaceFolderBasename}-26.08-cuda13.2-conda",
"${localEnv:USER:anon}-rapids-${localWorkspaceFolderBasename}-26.08-cuda13.3-conda",
"--ulimit",
"nofile=500000"
],
"containerEnv": {"PYTHON_VERSION": "3.13"},
"hostRequirements": {"gpu": "optional"},
"features": {
"./features/src/cuda": {
"version": "13.2",
"version": "13.3",
"installCompilers": false,
"installProfilers": true,
"installCTKLibraries": false,
Expand Down Expand Up @@ -51,7 +51,7 @@
"./features/src/utils",
"./features/src/rapids-build-utils"
],
"initializeCommand": ["/bin/bash", "-c", "mkdir -m 0755 -p ${localWorkspaceFolder}/../.{aws,cache,config,conda/pkgs,conda/${localWorkspaceFolderBasename}-cuda13.2-envs,log/devcontainer-utils} ${localWorkspaceFolder}/../{rmm,dask-cuda,kvikio,ucxx,cudf,rapidsmpf,raft,cuvs,cuml,nvforest,cugraph,cugraph-gnn,nx-cugraph,cuopt}"],
"initializeCommand": ["/bin/bash", "-c", "mkdir -m 0755 -p ${localWorkspaceFolder}/../.{aws,cache,config,conda/pkgs,conda/${localWorkspaceFolderBasename}-cuda13.3-envs,log/devcontainer-utils} ${localWorkspaceFolder}/../{rmm,dask-cuda,kvikio,ucxx,cudf,rapidsmpf,raft,cuvs,cuml,nvforest,cugraph,cugraph-gnn,nx-cugraph,cuopt}"],
"postAttachCommand": ["/bin/bash", "-c", "if [ ${CODESPACES:-false} = 'true' ]; then . devcontainer-utils-post-attach-command; fi"],
"workspaceFolder": "/home/coder",
"workspaceMount": "source=${localWorkspaceFolder},target=/home/coder/devcontainers,type=bind,consistency=consistent",
Expand All @@ -76,10 +76,10 @@
"source=${localWorkspaceFolder}/../.cache,target=/home/coder/.cache,type=bind,consistency=consistent",
"source=${localWorkspaceFolder}/../.config,target=/home/coder/.config,type=bind,consistency=consistent",
"source=${localWorkspaceFolder}/../.conda/pkgs,target=/home/coder/.conda/pkgs,type=bind,consistency=consistent",
"source=${localWorkspaceFolder}/../.conda/${localWorkspaceFolderBasename}-cuda13.2-envs,target=/home/coder/.conda/envs,type=bind,consistency=consistent",
"source=${localWorkspaceFolder}/../.conda/${localWorkspaceFolderBasename}-cuda13.3-envs,target=/home/coder/.conda/envs,type=bind,consistency=consistent",
"source=${localWorkspaceFolder}/../.log/devcontainer-utils,target=/var/log/devcontainer-utils,type=bind,consistency=consistent",
"source=${localWorkspaceFolder}/.devcontainer/cuda13.2-conda/features/src/utils/opt/devcontainer/bin,target=/opt/devcontainer/bin,type=bind,consistency=consistent",
"source=${localWorkspaceFolder}/.devcontainer/cuda13.2-conda/features/src/rapids-build-utils/opt/rapids-build-utils,target=/opt/rapids-build-utils,type=bind,consistency=consistent"
"source=${localWorkspaceFolder}/.devcontainer/cuda13.3-conda/features/src/utils/opt/devcontainer/bin,target=/opt/devcontainer/bin,type=bind,consistency=consistent",
"source=${localWorkspaceFolder}/.devcontainer/cuda13.3-conda/features/src/rapids-build-utils/opt/rapids-build-utils,target=/opt/rapids-build-utils,type=bind,consistency=consistent"
],
"customizations": {
"vscode": {
Expand Down
0 .devcontainer/cuda13.2-conda/features → .devcontainer/cuda13.3-conda/features
View file
Open in desktop
File renamed without changes.
18 changes: 9 additions & 9 deletions .devcontainer/cuda13.2-pip/devcontainer.json → .devcontainer/cuda13.3-pip/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,25 @@
"context": "${localWorkspaceFolder}/.devcontainer",
"dockerfile": "${localWorkspaceFolder}/.devcontainer/rapids.Dockerfile",
"args": {
"CUDA": "13.2",
"CUDA": "13.3",
"PYTHON_PACKAGE_MANAGER": "pip",
"BASE": "rapidsai/devcontainers:26.08-cpp-cuda13.2-ucx1.19.0-openmpi5.0.10"
"BASE": "rapidsai/devcontainers:26.08-cpp-cuda13.3-ucx1.19.0-openmpi5.0.10"
},
"cacheFrom": [
"ghcr.io/rapidsai/devcontainers/devcontainer:26.08-cuda13.2-pip"
"ghcr.io/rapidsai/devcontainers/devcontainer:26.08-cuda13.3-pip"
]
},
"runArgs": [
"--rm",
"--name",
"${localEnv:USER:anon}-rapids-${localWorkspaceFolderBasename}-26.08-cuda13.2-pip",
"${localEnv:USER:anon}-rapids-${localWorkspaceFolderBasename}-26.08-cuda13.3-pip",
"--ulimit",
"nofile=500000"
],
"hostRequirements": {"gpu": "optional"},
"features": {
"./features/src/cuda": {
"version": "13.2",
"version": "13.3",
"cuDNNVersion": "9",
"installcuBLAS": true,
"installcuDNN": true,
Expand All @@ -39,7 +39,7 @@
"./features/src/utils",
"./features/src/rapids-build-utils"
],
"initializeCommand": ["/bin/bash", "-c", "mkdir -m 0755 -p ${localWorkspaceFolder}/../.{aws,cache,config/pip,local/share/${localWorkspaceFolderBasename}-cuda13.2-venvs,log/devcontainer-utils} ${localWorkspaceFolder}/../{rmm,dask-cuda,kvikio,ucxx,cudf,rapidsmpf,raft,cuvs,cuml,nvforest,cugraph,cugraph-gnn,nx-cugraph,cuopt}"],
"initializeCommand": ["/bin/bash", "-c", "mkdir -m 0755 -p ${localWorkspaceFolder}/../.{aws,cache,config/pip,local/share/${localWorkspaceFolderBasename}-cuda13.3-venvs,log/devcontainer-utils} ${localWorkspaceFolder}/../{rmm,dask-cuda,kvikio,ucxx,cudf,rapidsmpf,raft,cuvs,cuml,nvforest,cugraph,cugraph-gnn,nx-cugraph,cuopt}"],
"postAttachCommand": ["/bin/bash", "-c", "if [ ${CODESPACES:-false} = 'true' ]; then . devcontainer-utils-post-attach-command; fi"],
"workspaceFolder": "/home/coder",
"workspaceMount": "source=${localWorkspaceFolder},target=/home/coder/devcontainers,type=bind,consistency=consistent",
Expand All @@ -63,10 +63,10 @@
"source=${localWorkspaceFolder}/../.aws,target=/home/coder/.aws,type=bind,consistency=consistent",
"source=${localWorkspaceFolder}/../.cache,target=/home/coder/.cache,type=bind,consistency=consistent",
"source=${localWorkspaceFolder}/../.config,target=/home/coder/.config,type=bind,consistency=consistent",
"source=${localWorkspaceFolder}/../.local/share/${localWorkspaceFolderBasename}-cuda13.2-venvs,target=/home/coder/.local/share/venvs,type=bind,consistency=consistent",
"source=${localWorkspaceFolder}/../.local/share/${localWorkspaceFolderBasename}-cuda13.3-venvs,target=/home/coder/.local/share/venvs,type=bind,consistency=consistent",
"source=${localWorkspaceFolder}/../.log/devcontainer-utils,target=/var/log/devcontainer-utils,type=bind,consistency=consistent",
"source=${localWorkspaceFolder}/.devcontainer/cuda13.2-pip/features/src/utils/opt/devcontainer/bin,target=/opt/devcontainer/bin,type=bind,consistency=consistent",
"source=${localWorkspaceFolder}/.devcontainer/cuda13.2-pip/features/src/rapids-build-utils/opt/rapids-build-utils,target=/opt/rapids-build-utils,type=bind,consistency=consistent"
"source=${localWorkspaceFolder}/.devcontainer/cuda13.3-pip/features/src/utils/opt/devcontainer/bin,target=/opt/devcontainer/bin,type=bind,consistency=consistent",
"source=${localWorkspaceFolder}/.devcontainer/cuda13.3-pip/features/src/rapids-build-utils/opt/rapids-build-utils,target=/opt/rapids-build-utils,type=bind,consistency=consistent"
],
"customizations": {
"vscode": {
Expand Down
0 .devcontainer/cuda13.2-pip/features → .devcontainer/cuda13.3-pip/features
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion .github/workflows/build-all-rapids-repos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:

with:
arch: '["amd64", "arm64"]'
cuda: '["12.9", "13.2"]'
cuda: '["12.9", "13.3"]'
node_type: cpu16
timeout-minutes: 720
# 1. Prohibit sccache from shutting down automatically
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/build-devcontainers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ on:
description: |
Stringified JSON array of CUDA versions to run this workflow for.
This is used to select .devcontainer/ directories local to wherever this workflow is invoked from.
For example, if a repository has directories '.devcontainer/cuda12.9-pip/' and '.devcontainer/cuda13.2-pip/',
'["12.9", "13.2"]' could be passed here to build both of those devcontainers in CI.
For example, if a repository has directories '.devcontainer/cuda12.9-pip/' and '.devcontainer/cuda13.3-pip/',
'["12.9", "13.3"]' could be passed here to build both of those devcontainers in CI.
type: string
default: '["12.9", "13.2"]'
default: '["12.9", "13.3"]'
python_package_manager:
description: |
Stringified JSON array of Python package managers to run devcontainer builds for.
Expand All @@ -30,10 +30,10 @@ on:
description: |
Stringified JSON array of CUDA versions to run this workflow for.
This is used to select .devcontainer/ directories local to wherever this workflow is invoked from.
For example, if a repository has directories '.devcontainer/cuda12.9-pip/' and '.devcontainer/cuda13.2-pip/',
'["12.9", "13.2"]' could be passed here to build both of those devcontainers in CI.
For example, if a repository has directories '.devcontainer/cuda12.9-pip/' and '.devcontainer/cuda13.3-pip/',
'["12.9", "13.3"]' could be passed here to build both of those devcontainers in CI.
type: string
default: '["12.9", "13.2"]'
default: '["12.9", "13.3"]'
python_package_manager:
description: |
Stringified JSON array of Python package managers to run devcontainer builds for.
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ jobs:
packages: write
with:
push: true
cuda: '["12.9", "13.2"]'
cuda: '["12.9", "13.3"]'

build-devcontainers-after-features-released:
if: needs.image-matrix.outputs.linux == '{"include":[]}' && (needs.features-matrix.outputs.features != '[]' || needs.features-matrix.outputs.scenarios != '[]')
Expand All @@ -152,4 +152,4 @@ jobs:
packages: write
with:
push: true
cuda: '["12.9", "13.2"]'
cuda: '["12.9", "13.3"]'
2 changes: 1 addition & 1 deletion .github/workflows/test-rapids-build-times.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:

with:
arch: '["amd64", "arm64"]'
cuda: '["12.9", "13.2"]'
cuda: '["12.9", "13.3"]'
node_type: ${{ inputs.node_type }}
timeout-minutes: 720
# 1. Prohibit sccache from shutting down automatically
Expand Down
2 changes: 1 addition & 1 deletion matrix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ x-cuda-prev-max: &cuda_prev_max { name: "cuda", version: "12.9" }
x-cuda-curr-min: &cuda_curr_min { name: "cuda", version: "13.0" }
x-cuda-curr-max: &cuda_curr_max { name: "cuda", version: "13.3" }
x-cuda-prev-max-rapids: &cuda_prev_max_rapids { name: "cuda", version: "12.9" }
x-cuda-curr-max-rapids: &cuda_curr_max_rapids { name: "cuda", version: "13.2" }
x-cuda-curr-max-rapids: &cuda_curr_max_rapids { name: "cuda", version: "13.3" }

# CUDA 12.0 support stops at gcc 12.
x-gcc-7: &gcc_7 { name: "gcc", version: "7" }
Expand Down
Loading