[5.x] Refactor input component styles#79
Open
Roene-JustBetter wants to merge 1 commit into
Open
Conversation
Removed unnecessary exclamation marks from ring classes.
Collaborator
|
I can remember that the important was necessary when you used tailwind in combination with the tailwind form plugin. That added custom css on inputs also targeting the rings. But maybe that has changed. Can you double check that? |
jordythevulder
requested changes
Jun 11, 2026
jordythevulder
left a comment
jordythevulder
left a comment
Collaborator
There was a problem hiding this comment.
See other comment
Member
Author
Checked it with |
Member
|
Let's wait for RAP-1908 so we can see possible visual differences |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need importants here this will break the ring on the inputs.