Reporting refactor - first iteration#21576
Draft
cdelafuente-r7 wants to merge 1 commit into
Draft
Conversation
cdelafuente-r7
added
blocked
cdelafuente-r7
force-pushed
the
reporting-refactoring
branch
2 times, most recently
from
9ee80ca to
fd99dec
Compare
- Add Errors, Reporter & Results - Add in_memory_backend, reporting test_helper & specs - Add db manager backend, connection pool & update reporter - Add Mdm::ModuleExecution lifecycle hooks - Add ModuleExecutionError capture - Update Gemfile to bring metasploit_data_models updates
cdelafuente-r7
force-pushed
the
reporting-refactoring
branch
from
fd99dec to
103a23a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the first iteration of the Metasploit reporting refactor. This project aims for a structured refactor of Metasploit reporting into a typed, backend-agnostic architecture that creates auditable execution records and consistent failure semantics across all reporting surfaces. The current system works in many success paths but has inconsistent behavior under failure and uneven attribution across module types and transports. This initiative addresses those reliability gaps while preserving delivery safety through additive, non-breaking iterations.
Current reporting behavior has three systemic issues:
Breaking Changes
There should not be any breaking changes for module contributors. Any new module type or execution step will have to follow the new workflow.
IMPORTANT This needs this PR to be landed first.
Reviewer Notes
TODO: This will be completed once this PR is ready.
Verification Steps
TODO: This will be completed once this PR is ready.
Test Evidence
TODO: This will be completed once this PR is ready.
AI Usage Disclosure
AI was used for this project (Copilot with Claude Opus 4.7 model) to help for the code analysis, the design and the implementation.
Pre-Submission Checklist
TODO: This will be completed once this PR is ready.
rubocopon new files with no new offenses (net new files only)msftidyon changed module files with no new offenses (modules only)msftidy_docson changed documentation files with no new offenses (documentation files only)documentation/modules(new modules only)lib/changes)