Model selection patch#242
Merged
Merged
Conversation
…ls removal - Add kneed to pyproject.toml dependencies (used in model_select.py) - Fix setup.py distutils.version.LooseVersion import removed in Python 3.12 - Update CI matrix to map each Python version to its latest compatible Gurobi: Python 3.8->11.0.3, Python 3.9-3.12->12.0.3 - Update Gurobi install steps to use matrix variables and auto-detect old (gurobi902/linux64/) vs new (gurobi11.0.3_linux64/) dir structure - Update FindGUROBI.cmake to handle both 9.x compact (gurobi902) and 10.x+ dotted (gurobi11.0.3_linux64) path formats when extracting the library suffix Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Remove unnecessary f-strings (F541) in model_select.py - Add blank line after import block in setup.py (ruff-format) - Add .venv/ to .gitignore Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Modern CMake (>=3.27) removed backward compatibility with versions <3.5, causing build failures. Also update the version check in setup.py to match. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Gurobi 10+ extracts to a compact 4-digit directory (e.g. gurobi1203 for 12.0.3). Add a new regex branch for this case so the lib suffix is computed correctly (first 3 digits -> libgurobi120.so). The three formats now handled: A) <=9.x compact: gurobi902 -> suffix "90" B) >=10.x compact: gurobi1203 -> suffix "120" C) >=10.x dotted: gurobi11.0.3 -> suffix "110" Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
simozacca
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compute_cn.model_selectto decide whether use old or new model-selection method by settingmodel_select=likelihoodormodel_select=objective, respectively.