ci: add GitHub Actions workflow for lint, test, and build - #55
Closed
t0kubetsu wants to merge 2 commits into
Closed
Conversation
Runs on every push and pull request to main: - npm ci (reproducible install) - npm run lint (ESLint) - npm run test:unit --run (Vitest) - npm run build (production build) Node.js 24 matches the Dockerfile base image. Closes #51.
- Fix double slash in /network//node/list API endpoint (closes #44) - Rename proxmoxSettingsStore Pinia ID to proxmoxSettingsV1 to avoid collision with useProxmoxSettings.js (closes #45) - Replace stale scaffold test with real App mount smoke test (closes #46) - Remove 30+ unused variables and imports across ProjectEditor.vue, Dashboard.vue, ConfigPanel.vue, Sidebar.vue, App.vue, and TS composables (closes #47, #48) - Add defineOptions multi-word names to Settings, Dashboard, Sidebar views (closes #48) - Gate vite-plugin-vue-devtools on mode === 'development' only (closes #49) - Rename package.json name from vue-project to range42-deployer-ui (closes #52) - Add typescript-eslint with TypeScript parser for Vue SFCs; fix vitest.config.js to resolve function-form vite config
Member
|
@pparage , could you please take care of reviewing and testing this PR? |
Member
Contributor
Author
|
Thanks for the clear context, @pparage. Just adding a note for the record: the replacement in
So the replacement is a proper superset of what was proposed here, not just an equivalent. One housekeeping note: issue #51 is still open — closing it now with a pointer to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.github/workflows/ci.ymlthat runs on every push and pull request tomain:npm ci— reproducible installnpm run lint— ESLintnpm run test:unit -- --run— Vitest unit testsnpm run build— production buildUses Node.js 24 on
ubuntu-latest, matching the project's Dockerfile.Closes #51
Test plan