Explicitly state Signature_Scheme::ECDSA_SECPxxxR1_TLS13_SHAxxx - #5772
Draft
reneme wants to merge 2 commits into
Draft
Explicitly state Signature_Scheme::ECDSA_SECPxxxR1_TLS13_SHAxxx#5772reneme wants to merge 2 commits into
reneme wants to merge 2 commits into
Conversation
reneme
force-pushed
the
rene/tls13_ecdsa_code_point_aliases
branch
3 times, most recently
from
July 29, 2026 14:17
4c23d39 to
08ffe8f
Compare
Collaborator
Author
|
Rebased after #5773 was merged. Also saw another opportunity to simplify the RFC8448 test case. |
TLS 1.3 explicitly means ECDSA on the NIST curves when using these code points. Other code points exist for the Brainpool curves (GH randombit#5771). In contrast, for TLS 1.2 these code points meant the usage of ECDSA on any curve paired with the specified hash function. To reflect this distinction in the code base, this introduces aliases in the Signature_Scheme enum accordingly.
reneme
force-pushed
the
rene/tls13_ecdsa_code_point_aliases
branch
from
July 29, 2026 14:35
386d047 to
40141a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For TLS 1.3 the implemented signature scheme codepoints for ECDSA imply "on the NIST curves" explicitly. Other concrete code points exist for ECDSA on the Brainpool curves (GH #5771) paired with the respective hash functions.
In contrast, for TLS 1.2 these code points are interpreted as ECDSA "on any curve" paired with the specified hash function. I think it makes sense to reflect this distinction in the
Signature_Schemeenum definition. However, since we are continuing to support TLS 1.2 we can't really deprecate the existing enum entries, in my opinion. Instead I just introduced aliases and some documentation explaining this mess...I mean this as a suggestion, addressing one of the points here, hence the "draft" status. I'm definitely open for better suggestions.