Skip to content

Enable KEM certificate issuance via CLI#5529

Open
falko-strenzke wants to merge 1 commit into
randombit:masterfrom
falko-strenzke:falko/mlkem-cert-cli
Open

Enable KEM certificate issuance via CLI#5529
falko-strenzke wants to merge 1 commit into
randombit:masterfrom
falko-strenzke:falko/mlkem-cert-cli

Conversation

@falko-strenzke

@falko-strenzke falko-strenzke commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator

Fixes #4516.

TODO

  • src/lib/x509/x509self.cpp: create_cert_req()
    • adds default extensions
  • src/lib/x509/x509_ca.cpp: X509_CA::choose_extensions():
    • add or update basic constraints based on req.is_CA()
    • add / replace further extensions
  • src/lib/x509/x509self.cpp: create_alt_name_ext()
    • set SAN value from opts

Comment thread src/cli/x509.cpp Outdated
Comment thread src/cli/x509.cpp Outdated

@randombit randombit left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic idea is fine, could be a lot simpler in implementation see prev comments

@mouse07410

Copy link
Copy Markdown
Contributor

@falko-strenzke as some of us eagerly await on this PR getting merged, might I ask you to address @randombit 's comments, or discuss with him why not...?

@falko-strenzke

Copy link
Copy Markdown
Collaborator Author

Now I realize there are quite a few things still missing, I noted the following:

     // - [ ] src/lib/x509/x509self.cpp: create_cert_req()
     //   - [ ] adds default extensions
     // - [ ] src/lib/x509/x509_ca.cpp: X509_CA::choose_extensions():
     //   - [ ] add or update basic constraints based on req.is_CA()
     //   - [ ] add / replace further extensions
     // - [ ] src/lib/x509/x509self.cpp: create_alt_name_ext()
     //   - [ ] set SAN value from opts

This might require some refactoring in order not to duplicate too much code. And the list might not be complete. I will have to postpone this for now.

@falko-strenzke
falko-strenzke force-pushed the falko/mlkem-cert-cli branch from b68622f to 3e6a5f3 Compare May 28, 2026 12:46
@falko-strenzke

Copy link
Copy Markdown
Collaborator Author

@randombit
From my side the PR is complete now. Let's see if the CI runs through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Question: how to create a certificate for ML-KEM pubkey?

3 participants