Enable KEM certificate issuance via CLI#5529
Open
falko-strenzke wants to merge 1 commit into
Open
Conversation
randombit
reviewed
Apr 15, 2026
randombit
reviewed
Apr 15, 2026
randombit
requested changes
Apr 15, 2026
randombit
left a comment
Owner
There was a problem hiding this comment.
Basic idea is fine, could be a lot simpler in implementation see prev comments
Contributor
|
@falko-strenzke as some of us eagerly await on this PR getting merged, might I ask you to address @randombit 's comments, or discuss with him why not...? |
Collaborator
Author
|
Now I realize there are quite a few things still missing, I noted the following: This might require some refactoring in order not to duplicate too much code. And the list might not be complete. I will have to postpone this for now. |
falko-strenzke
force-pushed
the
falko/mlkem-cert-cli
branch
from
May 28, 2026 12:46
b68622f to
3e6a5f3
Compare
Collaborator
Author
|
@randombit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4516.
TODO