Skip to content

Add Ninja build support for precompiled headers #5299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
randombit merged 2 commits into from
Feb 8, 2026
Merged

Add Ninja build support for precompiled headers #5299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a8069e
Initial plan
Copilot Feb 8, 2026
5e7f02d
Add PCH support to Ninja build system
Copilot Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2387,11 +2387,15 @@ def test_exe_extra_ldflags():

variables['pch_include_for_exe'] = '%s %s' % (cc.pch_include, os.path.join(build_paths.pch_dir, 'pch_exe.h'))
variables['pch_path_for_exe'] = os.path.join(build_paths.pch_dir, 'pch_exe.h.' + cc.pch_suffix)

variables['pch_target'] = 'pch'
else:
variables['pch_include_for_lib'] = ''
variables['pch_path_for_lib'] = ''
variables['pch_include_for_exe'] = ''
variables['pch_path_for_exe'] = ''

variables['pch_target'] = ''

variables['installed_include_dir'] = os.path.join(
variables['prefix'],
Expand Down
27 changes: 22 additions & 5 deletions src/build-data/ninja.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,27 @@ EXE_LINKS_TO = %{link_to_botan} ${LIB_LINKS_TO} %{extra_libs}
SCRIPTS_DIR = %{scripts_dir}
INSTALLED_LIB_DIR = %{libdir}

%{if enable_pch}
rule compile_pch_lib
command = %{cxx} %{lib_flags} ${ABI_FLAGS} ${LANG_FLAGS} ${CXXFLAGS} -DBOTAN_IS_BEING_BUILT ${WARN_FLAGS} %{public_include_flags} %{internal_include_flags} %{external_include_flags} %{pch_compile} %{dash_c} $in %{dash_o}$out

rule compile_pch_exe
command = %{cxx} ${ABI_FLAGS} ${LANG_FLAGS} ${CXXFLAGS} -DBOTAN_IS_BEING_BUILT ${WARN_FLAGS} %{public_include_flags} %{internal_include_flags} %{external_include_flags} %{pch_compile} %{dash_c} $in %{dash_o}$out

build %{pch_path_for_lib}: compile_pch_lib %{pch_dir}/pch_lib.h

build %{pch_path_for_exe}: compile_pch_exe %{pch_dir}/pch_exe.h

%{endif}

rule compile_lib
%{if header_deps_out}
depfile = $out.d
%{endif}
%{if ninja_header_deps_style}
deps = %{ninja_header_deps_style}
%{endif}
command = %{cxx} %{lib_flags} ${ABI_FLAGS} ${LANG_FLAGS} ${CXXFLAGS} -DBOTAN_IS_BEING_BUILT ${WARN_FLAGS} %{public_include_flags} %{internal_include_flags} %{external_include_flags} %{header_deps_flag} %{header_deps_out|concat: $out.d} %{dash_c} $in %{dash_o}$out
command = %{cxx} %{pch_include_for_lib} %{lib_flags} ${ABI_FLAGS} ${LANG_FLAGS} ${CXXFLAGS} -DBOTAN_IS_BEING_BUILT ${WARN_FLAGS} %{public_include_flags} %{internal_include_flags} %{external_include_flags} %{header_deps_flag} %{header_deps_out|concat: $out.d} %{dash_c} $in %{dash_o}$out

rule compile_exe
%{if header_deps_out}
Expand All @@ -37,7 +50,7 @@ rule compile_exe
%{if ninja_header_deps_style}
deps = %{ninja_header_deps_style}
%{endif}
command = %{cxx} ${ABI_FLAGS} ${LANG_FLAGS} ${CXXFLAGS} -DBOTAN_IS_BEING_BUILT ${WARN_FLAGS} %{public_include_flags} %{internal_include_flags} %{external_include_flags} %{header_deps_flag} %{header_deps_out|concat: $out.d} %{dash_c} $in %{dash_o}$out
command = %{cxx} %{pch_include_for_exe} ${ABI_FLAGS} ${LANG_FLAGS} ${CXXFLAGS} -DBOTAN_IS_BEING_BUILT ${WARN_FLAGS} %{public_include_flags} %{internal_include_flags} %{external_include_flags} %{header_deps_flag} %{header_deps_out|concat: $out.d} %{dash_c} $in %{dash_o}$out

rule compile_example_exe
%{if header_deps_out}
Expand Down Expand Up @@ -195,6 +208,10 @@ build libs: phony %{library_targets} $

build docs: phony %{doc_stamp_file}

%{if enable_pch}
build pch: phony %{pch_path_for_lib} %{pch_path_for_exe}
%{endif}

build clean: clean

build distclean: distclean
Expand All @@ -211,15 +228,15 @@ build tidy: tidy
# Build Commands

%{for lib_build_info}
build %{obj}: compile_lib %{src}
build %{obj}: compile_lib %{src} | %{pch_target}
%{endfor}

%{for cli_build_info}
build %{obj}: compile_exe %{src}
build %{obj}: compile_exe %{src} | %{pch_target}
%{endfor}

%{for test_build_info}
build %{obj}: compile_exe %{src}
build %{obj}: compile_exe %{src} | %{pch_target}
%{endfor}

%{for fuzzer_build_info}
Expand Down