FFI: add *_count() functions for DN enumerators - #5234
Merged
Conversation
reneme
changed the title
*_count() functions for DN enumerators
... these enumerator functions are pre-dating the BOTAN_FFI_ERROR_OUT_OF_BOUNDS and therefore still use BAD_PARAMETER for this situation. This commit also adds Botan4-TODOs to change that without breaking semver promises.
reneme
force-pushed
the
feature/ffi_count_for_dn
branch
from
January 13, 2026 08:30
2934216 to
2cfce7a
Compare
randombit
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested: #5232 (comment)
Note that these enumerator functions pre-date the
BOTAN_FFI_ERROR_OUT_OF_BOUNDSand therefore still use..._BAD_PARAMETERwhen theindexis out of range. This also adds Botan4-TODOs to change that without breaking semver promises.