Add CRL creation to FFI

[arckoor]

Adds methods to create, update and view CRLs to the FFI.
CRL part of #4877.

[coveralls]

coverage: 90.342% (+0.009%) from 90.333%
when pulling 457353a on arckoor:x509-crl-ffi
into 5166623 on randombit:master.

[Copilot]

Pull request overview

This pull request adds CRL (Certificate Revocation List) creation, updating, and viewing functionality to Botan's FFI, enhancing the library's X.509 certificate management capabilities. The changes include new FFI functions for CRL operations, corresponding Python bindings, comprehensive tests, and documentation.

Key Changes

• Added FFI functions for CRL creation (botan_x509_crl_create), updating (botan_x509_crl_update), and inspection
• Implemented Python wrapper classes (X509CRL, X509CRLReason, X509CRLEntry) with methods for CRL operations
• Introduced FFI API version 20260203 for Botan 3.11.0

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/lib/ffi/ffi_cert.h	New internal header declaring FFI certificate/CRL structure types
src/lib/ffi/ffi_cert.cpp	Implementation of CRL creation, update, viewing, and inspection functions
src/lib/ffi/ffi.h	Public FFI API declarations for new CRL functions and reason code enum
src/lib/ffi/ffi.cpp	FFI version support registration for API 20260203
src/lib/ffi/info.txt	Updated FFI version constant and added internal header
src/tests/test_ffi.cpp	C++ tests for CRL creation, updating, and verification
src/tests/data/x509/crl/ca.crt	Test CA certificate for CRL testing
src/tests/data/x509/crl/sub1.crt	Test subordinate certificate 1 for CRL testing
src/tests/data/x509/crl/sub2.crt	Test subordinate certificate 2 for CRL testing
src/python/botan3.py	Python bindings with X509CRL class, reason enum, and entry class
src/scripts/test_python.py	Python tests for CRL creation, revocation, and verification
doc/api_ref/ffi.rst	Documentation for new CRL-related FFI functions

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[arckoor]

@randombit I have removed the dependency on the python doc, so this is now a standalone PR. I hope this makes it a bit easier to take a look here.

[randombit]

Thanks for the rebase that helps a lot. Generally looks fine, I think though for the CRL entry getters we'll go with the approach added in #5220. It's probably easiest to just rebase this PR onto #5220 (or alternately wait for #5220 to merge then rebase onto master, which is a bit slower but likely to be less aggravating since there is a lot of FFI work going in at once for 3.11 it seems)

[reneme]

Frankly, I didn't realize that this PR had so much overlap with our work on #5220 and #5188. I'm sorry to barge in like that after it's been open for like six weeks. 😨

Anyway, I think we should ensure that the APIs for reading and writing CRLs are aligning nicely. I added some suggestions below.

Please note that despite having merged #5220 already, I don't consider those changes to be set in stone before they make it into a release. I'm definitely open to re-evaluate them as needed.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[arckoor]

I'd love to test this with ..., crl_entries, 2, ..., but asan won't let me (which is fair). In local testing it did return a ERR_NULL_POINTER like I expected though.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[randombit]

LGTM thanks @arckoor

@reneme did you have any final comments?

[reneme]

Looks good to me too. Thanks for adapting this to the botan_x509_crl_entry_t construction. Nice to see that this is now all concise. :)