Fix clang-tidy warning readability-qualified-auto - #4962
Merged
Conversation
randombit
force-pushed
the
jack/fix-clang-tidy-readability-qualified-auto
branch
4 times, most recently
from
July 6, 2025 17:19
1e31da5 to
de28120
Compare
reneme
approved these changes
Jul 9, 2025
Comment on lines
+37
to
+39
| // MSVC uses an actual iterator type for string_view, so we must use plain `auto` here | ||
| auto p1 = name1.begin(); // NOLINT(readability-qualified-auto) | ||
| auto p2 = name2.begin(); // NOLINT(readability-qualified-auto) |
This skips test_x509_rpki.cpp to avoid merge conflicts with other ongoing work, so the warning is not enabled in this commit.
randombit
force-pushed
the
jack/fix-clang-tidy-readability-qualified-auto
branch
from
July 9, 2025 11:23
de28120 to
0d57764
Compare
randombit
changed the title
Owner
Author
|
To avoid creating (more) awful merge conflicts for #4890 I reverted the changes to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.