Fix BOTAN_INCLUDE_DIR usage - #179
Open
butteronarchbtw wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The readme in
botan-syssuggests that if botan headers can be found infoo/botan-3/botan,BOTAN_INCLUDE_DIRshould only be set tofoo/, implying that thebotan-3/botanpath will be added by the build system.Currently, for the default search paths, the
botan-{major-version}suffix is appended to the basepath, but not toBOTAN_INCLUDE_DIRif it is set, i.e. it would need to be set tofoo/botan-3, which does not adhere to the readme.I've provided a draft implementation that searches in
BOTAN_INCLUDE_DIR/botan-{3,2}just like it does for the default paths.That however would prohibit the user to provide things such as
foo/botan/for theBOTAN_INCLUDE_DIR, where the headers are directly contained infoo/botan/, so the simpler fix could just be to update the readme :)