Skip to content

Embed the release tarball into the botan-src, instead of using a submodule - #178

Merged
randombit merged 1 commit into
masterfrom
jack/embed-release-tar-xz
May 7, 2026
Merged

Embed the release tarball into the botan-src, instead of using a submodule#178
randombit merged 1 commit into
masterfrom
jack/embed-release-tar-xz

Conversation

@randombit

@randombit randombit commented May 6, 2026

Copy link
Copy Markdown
Owner

This makes botan-src upgrades a lot simpler

Bump MSRV to 1.85; we needed 1.83 for some of the lzma_rs deps and 1.85 gets us the new rand 0.10 and 2024 Edition.

Bump botan-src to using Botan 3.12.0

@randombit
randombit force-pushed the jack/embed-release-tar-xz branch 3 times, most recently from 3ed20d4 to 8d9f5c8 Compare May 6, 2026 22:05
@arckoor

arckoor commented May 6, 2026

Copy link
Copy Markdown
Contributor

For some of my branches I often do -with-release versions where I e.g. specify my own fork in the submodule so that I don't have to wait 3 months to do proper testing in rust, will this still be somehow possible with this tarball approach?

@randombit
randombit force-pushed the jack/embed-release-tar-xz branch 4 times, most recently from bde0268 to 3ac9260 Compare May 6, 2026 23:09
@randombit

Copy link
Copy Markdown
Owner Author

For some of my branches I often do -with-release versions where I e.g. specify my own fork in the submodule so that I don't have to wait 3 months to do proper testing in rust, will this still be somehow possible with this tarball approach?

Now with BOTAN_SRC_DIR= and BOTAN_SRC_TARBALL= env overrides

@randombit
randombit force-pushed the jack/embed-release-tar-xz branch 2 times, most recently from 43c65cd to b63ae87 Compare May 7, 2026 00:34
@randombit
randombit force-pushed the jack/embed-release-tar-xz branch 4 times, most recently from 959d411 to ec8cbfd Compare May 7, 2026 02:53
@randombit randombit mentioned this pull request May 7, 2026
@randombit
randombit force-pushed the jack/embed-release-tar-xz branch 2 times, most recently from 79b3cb1 to 67f5539 Compare May 7, 2026 03:04
…odule

This makes botan-src upgrades a lot simpler

Bump MSRV to 1.85; we needed 1.83 for some of the lzma_rs deps and 1.85 gets
us the new `rand 0.10` and 2024 Edition.

Bump botan-src to using Botan 3.12.0
@randombit
randombit force-pushed the jack/embed-release-tar-xz branch from 67f5539 to 42cfc38 Compare May 7, 2026 03:06
@randombit
randombit merged commit 6869440 into master May 7, 2026
17 checks passed
@randombit
randombit deleted the jack/embed-release-tar-xz branch May 7, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants