Skip to content

Set namespace field when creating relationships for helm releases#487

Open
cienijr wants to merge 1 commit into
rancher:mainfrom
cienijr:fix-missing-namespace-field-helm-relationship
Open

Set namespace field when creating relationships for helm releases#487
cienijr wants to merge 1 commit into
rancher:mainfrom
cienijr:fix-missing-namespace-field-helm-relationship

Conversation

@cienijr

@cienijr cienijr commented Nov 22, 2024

Copy link
Copy Markdown

Fixes #486

@cienijr cienijr requested a review from a team as a code owner November 22, 2024 18:55
@cienijr cienijr changed the base branch from main to master November 22, 2024 19:00
@crobby crobby self-requested a review December 4, 2024 20:43
crobby
crobby previously requested changes Dec 4, 2024

@crobby crobby left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cienijr I believe this should be against the main branch rather than master. That is a change we made fairly recently. Thanks

@cienijr cienijr changed the base branch from master to main December 4, 2024 23:21
@cienijr

cienijr commented Dec 4, 2024

Copy link
Copy Markdown
Author

@crobby thanks for the help. I initially opened it against the main branch, but changed it after seeing a few other PRs in this repo. I reverted it back.

@crobby crobby self-requested a review December 5, 2024 18:00
@crobby crobby dismissed their stale review December 5, 2024 20:26

change made

@prachidamle prachidamle requested a review from gehrkefc December 6, 2024 17:53

@gehrkefc gehrkefc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crobby crobby left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me

@cienijr

cienijr commented Jan 31, 2025

Copy link
Copy Markdown
Author

Hello @crobby @gehrkefc 😄

Thank you both for reviewing and approving my PR. I'm not at all familiar with the Rancher development process and just wanted to check if there's anything else I should be doing to help land these changes. Please let me know if I can assist further 🚀

@cienijr

cienijr commented May 7, 2025

Copy link
Copy Markdown
Author

Hey there,

I see that no actions were ever run for my PR. Is this the blocker for getting this change upstream?
If so, what extra steps are required to run these checks?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resources listing for Helm charts breaks if the chart refers to another namespace

3 participants