Skip to content

[2.15] Use a sha-pinned version of setup-envtest#191

Merged
ericpromislow merged 2 commits into
rancher:mainfrom
ericpromislow:1899-hardening
Jul 8, 2026
Merged

[2.15] Use a sha-pinned version of setup-envtest#191
ericpromislow merged 2 commits into
rancher:mainfrom
ericpromislow:1899-hardening

Conversation

@ericpromislow

Copy link
Copy Markdown
Contributor

Ref #1899

@ericpromislow ericpromislow requested a review from a team as a code owner March 31, 2026 22:12
@ericpromislow ericpromislow changed the title Use a sha-pinned version of setup-envtest [2.15] Use a sha-pinned version of setup-envtest Mar 31, 2026
tomleb
tomleb previously requested changes Apr 10, 2026

@tomleb tomleb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep consistency with the other repository (steve), what do you think of using this script to install setup-envtest? https://github.com/rancher/steve/blob/main/scripts/install-envtest.sh

The script also checksums the binaries (apiserver / etcd) that are being installed by setup-envtest.

EDIT: Oops, meant this to be a comment

@crobby

crobby commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@ericpromislow Should we try to get this in?

@ericpromislow

Copy link
Copy Markdown
Contributor Author

Regarding @tomleb's suggestion, I can either run install-envtest in steve and copy/paste the workflow lines from steve into lasso, or I can copy the scripts from lasso into steve and run them there. But then I have to copy steve/gotools/setup-envtest/ as well, and have to keep the SHAs in lasso in sync with steve, and the versions in lasso's go.mod in sync with steve's. Sounds easier to just copy over the workflow command from steve.

@crobby crobby left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable approach.

@ericpromislow ericpromislow dismissed tomleb’s stale review July 8, 2026 23:02

Tom meant the text to be a comment, not a requested change

@ericpromislow ericpromislow merged commit faef14e into rancher:main Jul 8, 2026
1 check passed
@ericpromislow ericpromislow deleted the 1899-hardening branch July 8, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants