Skip to content

Merge Dev into Main - #3

Merged
ramyassaf merged 6 commits into
mainfrom
dev
May 24, 2026
Merged

Merge Dev into Main#3
ramyassaf merged 6 commits into
mainfrom
dev

Conversation

@ramyassaf

Copy link
Copy Markdown
Owner

No description provided.

Ramy ASSAF and others added 6 commits May 21, 2026 09:37
Runs ./gradlew test and ./gradlew assembleDebug on pull requests
and pushes targeting dev or main, plus manual workflow_dispatch.
Uses Temurin JDK 17 on ubuntu-latest with Gradle dependency caching
to keep re-runs fast.
…dows

GitHub Actions on Linux surfaced two bugs in the production-TODO
architecture rule that the Windows dev machine missed:

- file.path.contains("src/main/java") matches forward-slash paths
  only. On Windows the predicate was always false, making the rule a
  silent no-op. Replaced with Konsist's scopeFromProduction(), which
  targets the main source set without a path-string literal.

- contains("TODO", ignoreCase = true) matched the substring "todo"
  inside identifiers such as toDomainError. Dropped ignoreCase to
  align with the uppercase IDE/Kotlin convention for TODO markers.
The first CI run flagged actions/checkout@v4 and actions/setup-java@v4
as running on Node.js 20, which GitHub will remove from runners on
September 16, 2026. Both maintainers ship v5 releases that run on
Node.js 24 with identical inputs and behavior, so the upgrade is a
straight version bump.
ci: add GitHub Actions verification workflow
- Add CI verification notes to README and changelog
- Document Konsist architecture test coverage in testing docs
docs: document CI and architecture test coverage
@ramyassaf
ramyassaf merged commit 927718d into main May 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant