Skip to content

[feat/popover-landing]: popover 컴포넌트 추가 #7

Merged
ramong26 merged 3 commits into
mainfrom
feat/popover-landing
Jun 4, 2026
Merged

[feat/popover-landing]: popover 컴포넌트 추가 #7
ramong26 merged 3 commits into
mainfrom
feat/popover-landing

Conversation

@ramong26

@ramong26 ramong26 commented Jun 4, 2026

Copy link
Copy Markdown
Owner

요약

  1. 랜딩 페이지에 날짜 필터용 팝오버 UI를 추가
  2. 공용 Calendar / Popover 컴포넌트를 구현
  3. 날짜 선택 기능에 필요한 라이브러리를 추가

주요 변경 파일

파일 설명
src/shared/ui/Calendar.tsx react-day-picker 기반 공용 Calendar 컴포넌트 추가
src/shared/ui/Popover.tsx Portal 기반 공용 Popover 컴포넌트 추가
src/shared/assets/icons/ChevronDown.tsx 드롭다운 표시용 ChevronDown 아이콘 추가

변경 이유

  • 사용자가 날짜 기준으로 모임 목록을 필터링할 수 있는 UI를 제공하기 위해 추가
  • Calendar와 Popover를 공용 컴포넌트로 분리하여 다른 페이지에서도 재사용할 수 있도록 구성

참고 사항

  • 현재는 날짜 선택 UI만 구현되어 있으며 실제 필터링 로직은 포함되어 있지 않음
  • Popover는 Context + Portal 기반으로 구현하여 부모 레이아웃 및 overflow 영향을 받지 않도록 구성

@ramong26 ramong26 changed the title feat(shared-ui): 캘린더와 팝오버 컴포넌트 추가 [feat/popover-landing] Jun 4, 2026
@ramong26 ramong26 changed the title [feat/popover-landing] [feat/popover-landing]: popover 컴포넌트 추가 Jun 4, 2026
@ramong26 ramong26 self-assigned this Jun 4, 2026
@ramong26 ramong26 added the feat New feature or request label Jun 4, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a date filtering feature on the landing page by adding new custom Calendar and Popover UI components, along with dependencies like react-day-picker and date-fns. Feedback focuses on critical fixes and enhancements: correcting the lucide-react import syntax and fixing a CSS variable syntax error in Calendar.tsx to prevent compilation and layout issues; adding scroll position offsets and outside-click/Escape key event listeners in Popover.tsx to ensure correct positioning and usability; and removing unused empty <div> elements in LandingPage.tsx for cleaner code.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/shared/ui/Calendar.tsx
Comment thread src/shared/ui/Popover.tsx
Comment thread src/shared/ui/Popover.tsx
Comment thread src/shared/ui/Calendar.tsx
Comment thread src/pages/landing/ui/LandingPage.tsx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e54096578b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/shared/ui/Popover.tsx Outdated
@ramong26 ramong26 merged commit 51e10b3 into main Jun 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant