[feat/popover-landing]: popover 컴포넌트 추가 #7
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a date filtering feature on the landing page by adding new custom Calendar and Popover UI components, along with dependencies like react-day-picker and date-fns. Feedback focuses on critical fixes and enhancements: correcting the lucide-react import syntax and fixing a CSS variable syntax error in Calendar.tsx to prevent compilation and layout issues; adding scroll position offsets and outside-click/Escape key event listeners in Popover.tsx to ensure correct positioning and usability; and removing unused empty <div> elements in LandingPage.tsx for cleaner code.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e54096578b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
요약
주요 변경 파일
src/shared/ui/Calendar.tsxsrc/shared/ui/Popover.tsxsrc/shared/assets/icons/ChevronDown.tsx변경 이유
참고 사항
overflow영향을 받지 않도록 구성