Skip to content

Salyts' Ultimate Custom Tray: Fixed the DWORD Value that the mod checks for the icon theme mode#4489

Open
milestprower92 wants to merge 1 commit into
ramensoftware:mainfrom
milestprower92:main
Open

Salyts' Ultimate Custom Tray: Fixed the DWORD Value that the mod checks for the icon theme mode#4489
milestprower92 wants to merge 1 commit into
ramensoftware:mainfrom
milestprower92:main

Conversation

@milestprower92

Copy link
Copy Markdown

The mod originally looked for the 'AppsUseLightTheme' DWORD Value, Which checks if apps such as Settings, Clock, File Explorer. are using Light/Dark mode. Which as a side-effect makes the tray icon look bad in environments where people used light mode on apps, while still maintaining the dark mode taskbar.

So corrected this so it looks for the 'SystemUsesLightTheme' DWORD, so the icon actually matches with the taskbar's theme mode, when the icon theme mode is set to 'Auto'

Before:

image image

After:

image image

Changelog

If this pull request updates an existing mod, describe the changes below:

  • Changed the DWORD Value that the mod originally checked (AppsUseLightTheme) to (SystemUsesLightTheme) fixing the icon's theme mode in certain theme configurations

Mod authorship

If this pull request introduces a new mod, please complete the section below.

This mod was created by:

    • The submitter, without AI assistance
    • The submitter, with AI assistance
    • Claude
    • ChatGPT
    • Gemini
    • Another AI (please specify):
    • Other (please specify):

Please select the options that best apply. Your selection does not affect the acceptance criteria, but it helps reviewers understand the context of the code and provide relevant feedback.

…or the icon theme mde

The mod originally looked for the 'AppsUseLightTheme' DWORD Value, Which checks if apps such as Settings, Clock, File Explorer. are using Light/Dark mode.
Which as a side-effect makes the tray icon look bad in environments where people used light mode on apps, while still maintaining the dark mode taskbar.

So corrected this so it looks for the 'SystemUsesLightTheme' DWORD, so the icon actually matches with the taskbar's theme mode, when the icon theme mode is set to 'Auto'
@m417z

m417z commented Jun 22, 2026

Copy link
Copy Markdown
Member

Submission review

Note: This review was done by Claude, and then refined manually. Due to the amount of submissions, doing a fully manual review for each pull request is no longer feasible. Thank you for understanding.

Please address the following issues. The items in the collapsed sections are optional, so it's your call whether to address them.


  • This is a third‑party update to someone else's mod. The mod's @author is @Salyts, but this PR is submitted by a different account. Windhawk's ownership model is one responsible author per mod, and updates to a mod are expected to come from (or be coordinated with) that author. The cleanest path is to open an issue/PR on the original author's repo — github.com/Salyts/Ultimate-Custom-Tray — so the fix flows back through the maintainer of the mod.
Functionality notes

Non-critical observation about the feature behavior itself.

  • IsSystemDarkMode() is shared by both TrayIconUseWhite() (the tray icon) and MenuUseDark() (the right‑click context menu). This change therefore moves the context menu's "Auto" color from tracking the app theme to tracking the system/taskbar theme as well. For the tray icon that's exactly the intended fix; for the popup menu it's a defensible but slightly different default (a menu is more app-like than taskbar-like). If the intent is for the menu to keep following the app theme while only the icon follows the taskbar theme, the two would need to read different registry values. Low importance — just noting the coupled behavior so it's a deliberate choice rather than a side effect.

@milestprower92

Copy link
Copy Markdown
Author

Submission review

Note: This review was done by Claude, and then refined manually. Due to the amount of submissions, doing a fully manual review for each pull request is no longer feasible. Thank you for understanding.

Please address the following issues. The items in the collapsed sections are optional, so it's your call whether to address them.


  • This is a third‑party update to someone else's mod. The mod's @author is @Salyts, but this PR is submitted by a different account. Windhawk's ownership model is one responsible author per mod, and updates to a mod are expected to come from (or be coordinated with) that author. The cleanest path is to open an issue/PR on the original author's repo — github.com/Salyts/Ultimate-Custom-Tray — so the fix flows back through the maintainer of the mod.
Functionality notes

Non-critical observation about the feature behavior itself.

  • IsSystemDarkMode() is shared by both TrayIconUseWhite() (the tray icon) and MenuUseDark() (the right‑click context menu). This change therefore moves the context menu's "Auto" color from tracking the app theme to tracking the system/taskbar theme as well. For the tray icon that's exactly the intended fix; for the popup menu it's a defensible but slightly different default (a menu is more app-like than taskbar-like). If the intent is for the menu to keep following the app theme while only the icon follows the taskbar theme, the two would need to read different registry values. Low importance — just noting the coupled behavior so it's a deliberate choice rather than a side effect.

For the context menu, it kinda mimics how taskbar immersive context menu theme modes behave, where they sync with the taskbar theme mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants