Salyts' Ultimate Custom Tray: Fixed the DWORD Value that the mod checks for the icon theme mode#4489
Salyts' Ultimate Custom Tray: Fixed the DWORD Value that the mod checks for the icon theme mode#4489milestprower92 wants to merge 1 commit into
Conversation
…or the icon theme mde The mod originally looked for the 'AppsUseLightTheme' DWORD Value, Which checks if apps such as Settings, Clock, File Explorer. are using Light/Dark mode. Which as a side-effect makes the tray icon look bad in environments where people used light mode on apps, while still maintaining the dark mode taskbar. So corrected this so it looks for the 'SystemUsesLightTheme' DWORD, so the icon actually matches with the taskbar's theme mode, when the icon theme mode is set to 'Auto'
Submission reviewNote: This review was done by Claude, and then refined manually. Due to the amount of submissions, doing a fully manual review for each pull request is no longer feasible. Thank you for understanding. Please address the following issues. The items in the collapsed sections are optional, so it's your call whether to address them.
Functionality notes
Non-critical observation about the feature behavior itself.
|
For the context menu, it kinda mimics how taskbar immersive context menu theme modes behave, where they sync with the taskbar theme mode |
The mod originally looked for the 'AppsUseLightTheme' DWORD Value, Which checks if apps such as Settings, Clock, File Explorer. are using Light/Dark mode. Which as a side-effect makes the tray icon look bad in environments where people used light mode on apps, while still maintaining the dark mode taskbar.
So corrected this so it looks for the 'SystemUsesLightTheme' DWORD, so the icon actually matches with the taskbar's theme mode, when the icon theme mode is set to 'Auto'
Before:
After:
Changelog
If this pull request updates an existing mod, describe the changes below:
Mod authorship
If this pull request introduces a new mod, please complete the section below.
This mod was created by:
Please select the options that best apply. Your selection does not affect the acceptance criteria, but it helps reviewers understand the context of the code and provide relevant feedback.