feat: Glide V3 support - #23
Merged
Merged
Conversation
Owner
|
Hello @lao9s, thanks a lot! I like the PR and your decision to kick out the Symfony wrapper, this is much better. I am working right now on the next version of my Filament Media Library plugin and in that plugin we are using Glide. It is released in beta very soon and once that's out I have added this to my todo-list to test. So I will be coming back to this later. In the meantime if you need to install it I would just temporarily update your composer.json to the branch on your fork and then you can update back when released. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I’ve added support for Glide v3, which now uses Image Intervention v3.
I avoided using the
league/glide-symfonypackage because it’s stuck on Image Intervention v2 and there are unmerged PRs. Instead, I usedleague/glidedirectly and implemented the ResponseFactory within this package.I think this should become a new major version of the
laravel-glidepackage, so it can fully support users running Image Intervention v3 in their Laravel applications.