fix(hooks): initialize command buffer dispatch pointers#48
Merged
Conversation
Fixes a deadlock on startup triggered by the previous commit.
ralgar
force-pushed
the
fix/validation-layers
branch
from
336f419 to
281785e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command buffers are dispatchable objects. When allocated through the dispatch table directly, the loader trampoline is bypassed and the dispatch pointer is never fixed up, causing the validation layer to crash when looking up the device.
Hook vkAllocateCommandBuffers to fix up the dispatch pointer on all allocations, and route internal allocations through the hook rather than the dispatch table.
Fixes crash when using validation layers.
Also fixes a deadlock triggered by this PR, caused by unnecessary exclusive locking when reading from the instance dispatch map.