Conversation
Previously resolveToolPayloadRedaction() hardcoded mode tools, ignoring the logging.redactSensitive config entirely. This meant users who set redactSensitive off could not disable sensitive-value masking in tool event args like Authorization Bearer headers in web_fetch args. The fix reads redactSensitive from the logging config and passes it through normalizeMode(). When set to off, tool payload redaction is fully disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sanitizeToolArgs() and sanitizeToolResult() always redact secrets
in Control UI tool events, ignoring the user's logging.redactSensitive config.
Setting redactSensitive: off had no effect — Bearer tokens in tool args
still got replaced with B***r.
Root Cause
resolveToolPayloadRedaction() in src/logging/redact.ts hardcoded
mode: "tools" regardless of the logging.redactSensitive setting.
Fix
Read loggingConfig.redactSensitive and respect it:
Changes