Skip to content

Bump wasm-bindgen-utils to 0.1.2#226

Merged
thedavidmeister merged 1 commit into
mainfrom
2026-05-27-wasm-bindgen-utils-0.1
May 27, 2026
Merged

Bump wasm-bindgen-utils to 0.1.2#226
thedavidmeister merged 1 commit into
mainfrom
2026-05-27-wasm-bindgen-utils-0.1

Conversation

@thedavidmeister
Copy link
Copy Markdown
Contributor

@thedavidmeister thedavidmeister commented May 27, 2026

Moves wasm-bindgen-utils from 0.0.11 to 0.1.2 so downstream consumers (raindex, rain.metadata) resolve a single utils copy. 0.0.x and 0.1.x are semver-incompatible, so a mismatched tree otherwise produces two preludes and a missing try_from_js_value_ref ABI mismatch when raindex pulls Float in.

Changes

  • crates/float/Cargo.toml: wasm-bindgen-utils 0.0.110.1.2.
  • Add wasm-bindgen = "0.2.122" as a direct dependency.
  • Cargo.lock: wasm-bindgen family 0.2.1000.2.122 (utils 0.1.2 requires >=0.2.93); serde stays 1.0.219.

Why the direct wasm-bindgen dep

Without it, builds fail with an unbounded recursion limit reached while expanding #[wasm_bindgen] on the opaque-class structs (Float, FromFixedDecimalLossyResult) — the compiler keeps suggesting recursion_limit = "256" → 512 → 1024 … forever. The #[wasm_bindgen] macro emits ::wasm_bindgen paths; when the crate is only transitive those paths don't resolve and the macro re-expands without bound. Declaring wasm-bindgen directly (as rain.metadata's cli crate already does) fixes it with no source changes and no recursion_limit hack.

Verification

  • cargo check native + wasm32-unknown-unknown: clean.
  • cargo test -p rain-math-float: 76 + 36 tests pass.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to newer versions for improved compatibility and stability.

Review Change Stack

Moving wasm-bindgen-utils from 0.0.11 to 0.1.2 unifies the version with
raindex/rain.metadata so downstream consumers resolve a single utils copy
(0.0.x and 0.1.x are semver-incompatible, which otherwise produces two
preludes and a "missing try_from_js_value_ref" ABI mismatch).

0.1.2 requires wasm-bindgen >= 0.2.93, so the lock moves the wasm-bindgen
family 0.2.100 -> 0.2.122 (serde stays 1.0.219).

Crucially, wasm-bindgen is now a direct dependency. The #[wasm_bindgen]
macro emits `::wasm_bindgen` paths; when the crate is only a transitive
dep those paths fail to resolve and the 0.2.122 macro recurses without
bound on opaque-class structs (Float, FromFixedDecimalLossyResult) — the
compiler just keeps suggesting a larger recursion_limit forever. Declaring
wasm-bindgen directly (as rain.metadata already does) resolves it with no
source changes.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this May 27, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 432cdaca-9c34-4e62-8543-1b4f03504bf4

📥 Commits

Reviewing files that changed from the base of the PR and between 5a12bf8 and ef94717.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • crates/float/Cargo.toml

Walkthrough

The PR updates crates/float/Cargo.toml to add wasm-bindgen 0.2.122 as a direct dependency with explanatory comments and bumps wasm-bindgen-utils from 0.0.11 to 0.1.2 in the [dependencies] section.

Changes

WASM dependency updates

Layer / File(s) Summary
wasm-bindgen and wasm-bindgen-utils updates
crates/float/Cargo.toml
Added wasm-bindgen 0.2.122 as a direct dependency with comments explaining the macro path resolution requirement, and bumped wasm-bindgen-utils from 0.0.11 to 0.1.2.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: bumping wasm-bindgen-utils to 0.1.2, which is the primary version update in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-05-27-wasm-bindgen-utils-0.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thedavidmeister thedavidmeister merged commit a3c1a71 into main May 27, 2026
9 checks passed
@github-actions
Copy link
Copy Markdown

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Tip

For best results, initiate chat on the files or code changes.

SIZE=S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant