fix: prevent connection leak to pool on context cancellation during BeginTx - #17
Open
Kasuki354 wants to merge 1 commit into
Open
fix: prevent connection leak to pool on context cancellation during BeginTx#17Kasuki354 wants to merge 1 commit into
Kasuki354 wants to merge 1 commit into
Conversation
…eginTx When context is cancelled during BeginTx(), the connection may leak to the pool. This fix wraps BeginTx with proper context cancellation handling: on cancellation, waits for the goroutine to finish, then rolls back any partially created transaction to return the connection to the pool. Resolves raimeecas#2
|
😅 Unfortunately there are no rewards left to claim in this issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps BeginTx with context cancellation handling. On cancellation, waits for goroutine, rolls back partial transaction, returns connection to pool.
/claim #2