refactor: use custom error types consistently in store.py and linker.py#98
Merged
Merged
Conversation
raiderrobert
force-pushed
the
refactor/51/custom-error-types-consistency
branch
from
21cd876 to
921f551
Compare
Closes #51 - Wrap OSError in place_skill() with PlacementError (from errors.py) - linker.py now raises PlacementError for filesystem failures - Move __version__ and NAPOLN_DIR imports to module level - NAPOLN_DIR constant added to core/home.py
raiderrobert
force-pushed
the
refactor/51/custom-error-types-consistency
branch
from
921f551 to
4555fd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51