Skip to content

Fix gr_d3d_bitmap#349

Merged
rafalh merged 1 commit into
rafalh:masterfrom
is-this-c:dash_bitmap_fix
Dec 7, 2025
Merged

Fix gr_d3d_bitmap#349
rafalh merged 1 commit into
rafalh:masterfrom
is-this-c:dash_bitmap_fix

Conversation

@is-this-c

Copy link
Copy Markdown
Contributor

No description provided.

@rafalh rafalh left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain exactly why is it too late and what consequence it has? I don't see a problem in the code on the first glance.

@is-this-c

Copy link
Copy Markdown
Contributor Author

gr_use_current_color is read before calling gr_d3d_set_state so e.g. text may have wrong color.

     if ( gr_use_current_color )
        {
          green = gr_screen.current_color.green;
          red = gr_screen.current_color.red;
          r = gr_screen.current_color.red;
          blue = gr_screen.current_color.blue;
          g = gr_screen.current_color.green;
          b = gr_screen.current_color.blue;
        }
        else
        {
          blue = 255;
          green = 255;
          red = 255;
          b = 255;
          g = 255;
          r = 255;
        }

@rafalh

rafalh commented Dec 7, 2025

Copy link
Copy Markdown
Owner

gr_use_current_color is read before calling gr_d3d_set_state so e.g. text may have wrong color.

Thanks, this makes sense

@rafalh rafalh merged commit b5a8c06 into rafalh:master Dec 7, 2025
2 checks passed
@rafalh

rafalh commented Dec 7, 2025

Copy link
Copy Markdown
Owner

What is the meaning of #199 in the title? It does not seem to be related to issue with that number

@is-this-c

Copy link
Copy Markdown
Contributor Author

It must be from AF.

@is-this-c is-this-c changed the title Fix gr_d3d_bitmap (#199) Fix gr_d3d_bitmap Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants