Re-request reviews after addressing changes#276
Merged
Conversation
Add a re-request review instruction to the changes-requested prompt so Claude Code automatically runs `gh pr edit --add-reviewer` (or `glab mr update --reviewer` for GitLab) after pushing fixes, notifying the original reviewers that their feedback has been addressed. 🤖 Generated with Claude Code, orchestrated by Crow Co-Authored-By: Claude <noreply@anthropic.com> Crow-Session: 3D3AC58B-7D51-487C-8B99-DF6E514F6C4F
dhilgaertner
approved these changes
May 15, 2026
Contributor
dhilgaertner
left a comment
There was a problem hiding this comment.
Code & Security Review
Critical Issues
None — change is a 4-line string augmentation to the changesRequested auto-respond prompt.
Security Review
Strengths:
- No new shell invocation surface in Crow itself; the appended hint is text injected into a managed terminal for Claude Code to act on.
transition.prURLis already interpolated into the existingfetchHintin the same string, so this introduces no new injection vector. - No new API scopes, secrets, or auth flows. Consistent with the file's stated design (
Crow does not fetch review bodies or CI logs itself). - Manual
addressChangesquick-action path inherits the change for free viaAutoRespondPrompts.build()(Sources/Crow/App/AutoRespondCoordinator.swift:168), avoiding drift between auto and manual flows.
Concerns:
- None.
Code Quality
- Yellow —
glab mr update --reviewersemantics (Sources/Crow/App/AutoRespondCoordinator.swift:122): Unlikegh pr edit --add-reviewer, the GitLabglab mr update --reviewer <login>flag sets the reviewer list rather than appending. Running it once per reviewer (as the prompt instructs: "for each one") would only leave the last login as the reviewer, dropping the others. Consider either (a) instructing Claude to pass a comma-separated list in a single invocation, or (b) noting the set-vs-add distinction so Claude doesn't iterate. The GitHub path is fine —--add-revieweris additive. - Green — Prompt length (Sources/Crow/App/AutoRespondCoordinator.swift:128): The
changesRequestedprompt is now noticeably longer, still on a single line. Given the existing single-line +\ncontract documented at the top ofAutoRespondPrompts(line 106-110), this is fine, but worth keeping an eye on if more hints accumulate. - Green — No tests: There are no tests covering
AutoRespondPrompts.build()in the repo, so the substring change is verified manually only. A small snapshot-style test asserting the prompt contains bothgh pr editand--add-reviewerfor GitHub andglab mr update/--reviewerfor GitLab would lock down the contract cheaply. Not a blocker.
Summary Table
| Priority | Issue |
|---|---|
| 🟡 Yellow | glab mr update --reviewer replaces reviewers; iterating per-login will drop earlier ones (line 122) |
| 🟢 Green | Consider a snapshot test for the prompt strings to prevent silent regressions |
| 🟢 Green | Prompt is approaching a chunky single line — monitor as more hints are appended |
Recommendation: Approve. The change is low-risk, small, and the manual quick-action path is correctly covered via shared AutoRespondPrompts.build(). The GitLab semantics nit is worth a follow-up but doesn't block merge — Claude Code can self-correct when the command behaves unexpectedly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
changesRequestedauto-respond prompt inAutoRespondCoordinatorgh pr edit --add-reviewer <login>(GitHub) orglab mr update --reviewer <login>(GitLab) to re-request review from each reviewer who requested changesAutoRespondPrompts.build()Closes #275
Test plan
gh pr edit --add-reviewer🤖 Generated with Claude Code