Revert Deployment Engine image tag pin in Helm chart#11906
Open
brooke-hamilton wants to merge 1 commit into
Open
Revert Deployment Engine image tag pin in Helm chart#11906brooke-hamilton wants to merge 1 commit into
brooke-hamilton wants to merge 1 commit into
Conversation
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the Helm chart’s temporary pin of the Deployment Engine (de) image tag so the chart again defaults to using a tag derived from the chart AppVersion (via the chart helper logic), consistent with other control-plane components.
Changes:
- Removed the hardcoded
de.tag: 0.56value fromdeploy/Chart/values.yaml. - Updated inline comments to reflect the defaulting behavior when
de.tagis unset.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11906 +/- ##
==========================================
- Coverage 51.74% 51.72% -0.03%
==========================================
Files 726 726
Lines 45605 45605
==========================================
- Hits 23597 23587 -10
- Misses 19788 19794 +6
- Partials 2220 2224 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Radius functional test overviewClick here to see the test run details
Test Status⌛ Building Radius and pushing container images for functional tests... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts the Deployment Engine (
de) image tag pin indeploy/Chart/values.yaml. The tag was previously pinned to0.56for the v0.57.1 patch release. With that release out, the chart should fall back to using the ChartAppVersionas the default tag.Type of change