Include social profile fields in admin user detail lookup#62
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cdsaidev
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UsersService.getById) was returningnullfor all social profile fields (LinkedIn, Twitter, Facebook, GitHub, portfolio, Telegram, WhatsApp), even when the user had submitted an application containing them.toUserDtoalready accepts an optionalsocialsargument sourced from the user'sApplicationrecord, butgetByIdwasn't fetching or passing it — so the admin detail view silently dropped this data.Promise.all), and pass the application data intotoUserDtoso the detail view is populated correctly. Falls back tonullper field when the user has no application.Changes
backend/src/modules/users/users.service.ts:getByIdnow also queriesapplication.findUnique(selecting only the social fields) and passes the result totoUserDtobackend/test/unit/modules/users/users.service.spec.ts: added tests covering (1) social fields populated from the application record, and (2) fields default tonullwhen no application existsTest plan
users.service.spec.ts