Trim portfolio URL before validation to fix false-positive rejection

[engdotme]

Summary

• Portfolio URLs with incidental leading/trailing whitespace (e.g. pasted from a browser address bar) were being rejected as invalid, even though the URL itself was valid.
• Root cause: @IsUrl() (backend) and Zod's .url() (frontend) don't tolerate surrounding whitespace, while the WHATWG URL parser used elsewhere does — creating an inconsistent, surprising validation failure.
• Fix: trim the portfolio field before validation in both the application and profile DTOs (backend, via class-transformer's @Transform) and in the shared optionalUrl Zod helper (frontend), so whitespace no longer causes a false-positive rejection.

Changes

• backend/src/modules/account/dto/update-profile.dto.ts: trim portfolio before @IsUrl()
• backend/src/modules/applications/dto/create-application.dto.ts: trim portfolio before @IsUrl()
• frontend/src/constants/shared/social-profiles.ts: add .trim() to optionalUrl
• Added tests covering: whitespace-padded valid URLs are accepted, and non-URL values remain rejected after trimming

Test plan

• Unit tests added/updated for backend DTOs (account/dto.spec.ts, applications/dto.spec.ts) and frontend schemas (apply-form.test.ts, profile-form-schema.test.ts)
• Manually verify: submitting a profile/application form with a portfolio URL containing leading/trailing spaces succeeds

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
forgeng-frontend	Ready	Preview, Comment	Jul 5, 2026 4:00pm

[github-actions]

Backend coverage

Backend coverage

Lines	Statements	Branches	Functions
	71.41% (1434/2008)	64.93% (852/1312)	73.78% (273/370)

[github-actions]

Frontend coverage

Frontend coverage

Lines	Statements	Branches	Functions
	31.29% (819/2617)	24.61% (400/1625)	25.56% (192/751)

[cdsaidev]

Good job, thanks