Change ERB=>Ruby Processing Strategy#70
Open
ccutrer wants to merge 1 commit into
Open
Conversation
Instead of putting each ERB node into "separate" Ruby blocks for feeding to RuboCop, use `Herb.extract_ruby`. This means we don't need to strip out statements split across multiple ERB tags, or ignore Lint/Syntax. But we need to prevent any regular RuboCop autocorrects from breaking non-Ruby characters in an ERB file. Many more cops that would now have false positives without knowing that the ERB content exists (such as not knowing about the bodies of conditionals, or that ERB output is not void), or warn about the resulting Ruby from `Herb.extract_ruby` (mostly the semicolons), have been disabled. They'll be re-enabled in future PRs that will make them aware of the ERB context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of putting each ERB node into "separate" Ruby blocks for feeding to RuboCop, use
Herb.extract_ruby. This means we don't need to strip out statements split across multiple ERB tags, or ignore Lint/Syntax.But we need to prevent any regular RuboCop autocorrects from breaking non-Ruby characters in an ERB file.
Many more cops that would now have false positives without knowing that the ERB content exists (such as not knowing about the bodies of conditionals, or that ERB output is not void), or warn about the resulting Ruby from
Herb.extract_ruby(mostly the semicolons), have been disabled. They'll be re-enabled in future PRs that will make them aware of the ERB context.