Use chained errors in subscript checks - #1735
Open
lionel- wants to merge 12 commits into
Open
Conversation
lionel-
marked this pull request as draft
October 20, 2022 15:08
lionel-
force-pushed
the
chained-subscript-errors
branch
from
October 20, 2022 16:17
2b0a03b to
6550fd6
Compare
lionel-
marked this pull request as ready for review
October 21, 2022 12:14
hadley
reviewed
Oct 21, 2022
hadley
left a comment
hadley
left a comment
Member
There was a problem hiding this comment.
I started reviewing this overall it seems like quite a lot of work for a results that's feels to me like a net neutral (or even a slight decline, since most of the errors now need extra line). So I think I must be missing some context or motivation.
| Error in `my_function()`: | ||
| ! Must subset elements with a valid subscript vector. | ||
| x Can't convert from `my_arg` <double> to <integer> due to loss of precision. | ||
| ! Can't subset elements with `my_arg`. |
Member
There was a problem hiding this comment.
What does the chaining buy us here? Couldn't this be:
! Can't subset elements with `my_arg`.
i Can't convert from <double> to <integer> due to loss of precision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.